This repository was archived by the owner on Jun 5, 2025. It is now read-only.
Fix log timestamp format - #147
Merged
Merged
Conversation
David Bennett (dkbennett)
requested review from
Eric Johnson (EricJohnson327),
Felipe G (guimafelipe) and
Kristen Schau (krschau)
April 9, 2024 16:00
David Bennett (dkbennett)
marked this pull request as ready for review
April 9, 2024 16:01
Kristen Schau (krschau)
approved these changes
Apr 9, 2024
Felipe G (guimafelipe)
approved these changes
Apr 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the pull request
Timestamp format was incorrect for the logging, putting minutes instead of months and creating an invalid timestamp. It also fails to parse as a DateTime which broke tooling.
References and relevant issues
Closes #146
Detailed description of the pull request / Additional comments
Validation steps performed
PR checklist