Remove VS checks that assume Visual Studio is installed on C: drive#3157
Merged
hekota merged 1 commit intomicrosoft:masterfrom Sep 23, 2020
Merged
Remove VS checks that assume Visual Studio is installed on C: drive#3157hekota merged 1 commit intomicrosoft:masterfrom
hekota merged 1 commit intomicrosoft:masterfrom
Conversation
These checks were there only to provide a nice error message when VS 2019 is not installed but it does not take into account that it can be installed at other locations than the default one. Removing these will still result in an error from cmake if it can't find Visual Studio installed.
pow2clk
approved these changes
Sep 22, 2020
Collaborator
pow2clk
left a comment
pow2clk
left a comment
There was a problem hiding this comment.
Looks good!
I think it's cmake that fails to find the compiler and produces the error now?
Member
Author
|
Correct. |
|
✅ Build DirectXShaderCompiler 1.0.3656 completed (commit 59ad3419da by @hekota) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These checks were there only to provide a nice error message when VS 2019 is not installed but it does not take into account that it can be installed at other locations than the default one. Removing these will still result in an error from cmake if it can't find Visual Studio installed.
Fixes #3151