Remove unneeded atomicstest dependency#3631
Merged
tex3d merged 1 commit intomicrosoft:masterfrom Mar 26, 2021
Merged
Conversation
The 32-bit atomics test variant was requiring a UAV type unnecessarily. By using structured buffers for groupshared output, this dependency is removed.
|
✅ Build DirectXShaderCompiler 1.0.4675 completed (commit fae54e8d7d by @pow2clk) |
tex3d
pushed a commit
to tex3d/DirectXShaderCompiler
that referenced
this pull request
Mar 26, 2021
The 32-bit atomics test variant was requiring a UAV type unnecessarily. By using structured buffers for groupshared output, this dependency is removed. (cherry picked from commit 73a6706)
tex3d
added a commit
that referenced
this pull request
Mar 26, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 32-bit atomics test variant was requiring a UAV type unnecessarily.
By using structured buffers for groupshared output, this dependency is
removed.