Clean more TODOs for Validation and Dxil generation.#4
Merged
python3kgae merged 2 commits intomasterfrom Jan 4, 2017
Merged
Conversation
|
Hi @python3kgae, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
TTYL, MSBOT; |
python3kgae
added a commit
that referenced
this pull request
Jan 20, 2017
Strip function parameter for entry and patch constant function * Update error message for ValidationTest::MultiDimArray * Merge remote-tracking branch 'origin/master' # Conflicts: # lib/HLSL/DxilValidation.cpp # tools/clang/unittests/HLSL/ValidationTest.cpp * Update error message for ValidationTest::MultiDimArray Update error message for ValidationTest::MultiDimArray * Fix merge error. (#3) * Delete local file (#4) * Fix merge error. * Delete local file * Strip function parameter for entry and patch constant function. (#5)
python3kgae
referenced
this pull request
in python3kgae/DirectXShaderCompiler
Jan 26, 2017
* Fix merge error. * Delete local file
yskim1501
added a commit
to yskim1501/DirectXShaderCompiler
that referenced
this pull request
Feb 7, 2017
* Clean up dxc options: setrootsignature, setprivate : Allow replacing existing rootsignature or private data and make a new container with new parts (e.g dxc /dumpbin private.dxil /setprivate private.data /Fo private.new.dxil) extractrootsignature: Make it back compatible with fxc by returning dxil container with RTS0 part only and having the user to provide /Fo option. Other Options: For unimplemented options that was from fxc, ignore those options and proceed given operation. For unimplemented options that was not from fxc, remove them for now. Add more test cases for dxc command line operations. Fix ISenseOption flag to have valid HLSL version check for dxc (disable 2015) * Fix Preprocess option for dxc Fix hcttestcmd for testing invalid rootsignature
damyanp
referenced
this pull request
in damyanp/DirectXShaderCompiler
Mar 22, 2025
This proposal suggests adopting C and C++ initializer list rules and behaviors. This is source incompatible and may cause disruption to developers. As we flesh the proposal out further we will seek to address migration issues as well as ensure that we can properly diagnose incompatibilities.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.