Add missing headers for clang with libc++ builds#5285
Merged
tex3d merged 1 commit intomicrosoft:mainfrom Jun 15, 2023
Merged
Conversation
chrisbieneman
approved these changes
Jun 13, 2023
Collaborator
chrisbieneman
left a comment
chrisbieneman
left a comment
There was a problem hiding this comment.
LGTM. We do require a PR description even for simple changes.
I needed to add these headers to successfully build DXC with clang and libc++.
amaiorano
force-pushed
the
add-missing-includes-clang-libc++
branch
from
c07f316 to
74d5988
Compare
Collaborator
Author
Added a PR description. |
tex3d
approved these changes
Jun 15, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add these headers to successfully build DXC with clang and libc++.