[Diag] Diagnose missing numthreads in compute shaders#6021
Merged
bogner merged 2 commits intoNov 16, 2023
Merged
Conversation
Created using spr 1.3.5
llvm-beanz
approved these changes
Nov 15, 2023
llvm-beanz
reviewed
Nov 15, 2023
bob80905
approved these changes
Nov 15, 2023
damyanp
approved these changes
Nov 15, 2023
Created using spr 1.3.5
bogner
added a commit
to bogner/DirectXShaderCompiler
that referenced
this pull request
Nov 15, 2023
Currently we error out in validation if a compute shader doesn't have a numthreads attribute: ``` <source>:2: error: Declared Thread Group X size 2833376888 outside valid range [1..1024]. <source>:2: error: Declared Thread Group Y size 21956 outside valid range [1..1024]. <source>:2: error: Declared Thread Group Z size 2833381336 outside valid range [1..64]. <source>:2: error: Declared Thread Group Count 3863291136 (X*Y*Z) is beyond the valid maximum of 1024. ``` Instead, diagnose this in Sema like we do for mesh and amplitude shaders Pull Request: microsoft#6021
llvm-beanz
approved these changes
Nov 15, 2023
bogner
deleted the
users/bogner/spr/diag-diagnose-missing-numthreads-in-compute-shaders
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently we error out in validation if a compute shader doesn't have
a numthreads attribute:
Instead, diagnose this in Sema like we do for mesh and amplitude shaders