[Diag] Warn instead of error on invalid numthreads#6023
Merged
bogner merged 4 commits intoNov 16, 2023
Merged
Conversation
Created using spr 1.3.5 [skip ci]
Created using spr 1.3.5
bogner
changed the title
damyanp
approved these changes
Nov 15, 2023
bob80905
approved these changes
Nov 15, 2023
pow2clk
reviewed
Nov 15, 2023
bogner
added a commit
to bogner/DirectXShaderCompiler
that referenced
this pull request
Nov 15, 2023
If an invalid numthreads attribute isn't used, erroring out on it is a breaking change that might be annoying to deal with. Instead we make invalid numthreads a warning and drop the attribute - we can rely on the existing diagnostics for missing numthreads to error out in cases that aren't recoverable. Pull Request: microsoft#6023
llvm-beanz
approved these changes
Nov 15, 2023
Created using spr 1.3.5 [skip ci]
bogner
changed the base branch from
users/bogner/spr/main.diags-warn-instead-of-error-on-invalid-numthreads
to
main
bogner
deleted the
users/bogner/spr/diags-warn-instead-of-error-on-invalid-numthreads
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If an invalid numthreads attribute isn't used, erroring out on it is a
breaking change that might be annoying to deal with. Instead we make
invalid numthreads a warning and drop the attribute - we can rely on
the existing diagnostics for missing numthreads to error out in cases
that aren't recoverable.