[SPIR-V][vk::SampledTexture] #7. Add subscriptor indexing methods for vk::SampledTexture2D type. #8158
Merged
s-perron merged 2 commits intomicrosoft:mainfrom Mar 3, 2026
Merged
Conversation
luciechoi
changed the title
[] and .mips[] for SampledTexture2Dvk::SampledTexture2D type.
luciechoi
changed the title
vk::SampledTexture2D type. vk::SampledTexture2D type.
luciechoi
force-pushed
the
subscript
branch
2 times, most recently
from
1f5c177 to
dda833e
Compare
s-perron
approved these changes
Feb 27, 2026
Keenuts
approved these changes
Mar 2, 2026
Collaborator
Author
|
(cc: @s-perron next CL to be merged) |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
s-perron
approved these changes
Mar 2, 2026
auto-merge was automatically disabled
March 2, 2026 22:48
Head branch was pushed to by a user without write access
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
s-perron
approved these changes
Mar 2, 2026
dj2
reviewed
Mar 3, 2026
| ResClass = DXIL::ResourceClass::UAV; | ||
| return true; | ||
| case AR_OBJECT_TEXTURE2D: | ||
| case AR_OBJECT_VK_SAMPLED_TEXTURE2D: |
There was a problem hiding this comment.
I believe this needs to be wrapped inside an #if ENABLE_SPIRV_CODEGEN as the AR_OBJECT_VK_SAMPLED_TEXTURE2D is wrapped inside that preprocessor flag.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #7979
Support subscriptor indexing
[]and.mips[]forSampledTexture2D..sample[]will not be allowed, as inTexture2D.