Skip to content

Fix spelling errors - #8257

Merged
Damyan Pepper (damyanp) merged 4 commits into
mainfrom
copilot/fix-typos-in-codebase
Jul 7, 2026
Merged

Fix spelling errors#8257
Damyan Pepper (damyanp) merged 4 commits into
mainfrom
copilot/fix-typos-in-codebase

Conversation

Copilot AI commented Mar 10, 2026

Copy link
Copy Markdown
Contributor

This fixes typos in DXC-specific files identified in #8230

  • agressiveaggressive - HLSLOptions.td
  • ingoredignored - HLSLOptions.td, SPIR-V.rst
  • specfiedspecified - HLSLOptions.td
  • convertableconvertible - DiagnosticSemaKinds.td
  • ouputoutput - DiagnosticSemaKinds.td, CGHLSLMS.cpp

Copilot AI and others added 2 commits March 10, 2026 18:08
Co-authored-by: damyanp <8118402+damyanp@users.noreply.github.com>
Co-authored-by: damyanp <8118402+damyanp@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix various typos in the codebase Fix spelling errors detected by linux packaging tools Mar 10, 2026

@damyanp Damyan Pepper (damyanp) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please limit these changes to:

  • ones that directly impact the generated binaries
  • ones in SPIR-V.rst

In particular, avoid editing files that look like they have been untouched from upstream.

… and SPIR-V.rst

Co-authored-by: damyanp <8118402+damyanp@users.noreply.github.com>

Copilot AI commented Mar 10, 2026

Copy link
Copy Markdown
Contributor Author

Please limit these changes to:

  • ones that directly impact the generated binaries...

Reverted all changes to upstream LLVM/Clang files and comment-only changes in 696092f. The PR now only touches:

  • include/dxc/Support/HLSLOptions.td — HelpText strings in binaries
  • tools/clang/include/clang/Basic/DiagnosticSemaKinds.td — DXC-specific diagnostic messages
  • tools/clang/lib/CodeGen/CGHLSLMS.cpp — DXC custom diagnostic string
  • docs/SPIR-V.rst
  • Two DXC test files updated to match the changed diagnostics

@damyanp
Damyan Pepper (damyanp) marked this pull request as ready for review March 10, 2026 21:41
@damyanp

Copy link
Copy Markdown
Member

Copilot are you able to verify that lintian no longer reports these spelling errors?

Copilot AI commented Mar 10, 2026

Copy link
Copy Markdown
Contributor Author

Copilot are you able to verify that lintian no longer reports these spelling errors?

I can't build and run lintian in this sandbox, but I can provide a static analysis. This PR fixes 5 of the 17 reported spelling errors — specifically the ones in DXC-specific files that produce string literals in the binaries:

Fixed by this PR:

Typo Correction File(s)
agressive aggressive HLSLOptions.td
ingored ignored HLSLOptions.td
specfied specified HLSLOptions.td
convertable convertible DiagnosticSemaKinds.td
ouput output DiagnosticSemaKinds.td, CGHLSLMS.cpp

Remaining — all in upstream LLVM/Clang files (excluded per your request):

Typo File(s)
initalizer lib/IR/Verifier.cpp (assert string)
missmatch lib/IR/Constants.cpp, lib/AsmParser/LLParser.cpp (assert strings)
varaible lib/IR/Verifier.cpp (assert string)
overriden tools/clang/include/clang/Driver/Options.td (HelpText string)

Not located in source (possibly from generated code, third-party, or lintian false positives):
TAht, TeH, componet

@damyanp Damyan Pepper (damyanp) changed the title Fix spelling errors detected by linux packaging tools Fix spelling errors Mar 10, 2026
@damyanp

Copy link
Copy Markdown
Member

Copilot update the PR description to describe which typos have been fixed. Don't say anything about things you didn't do, just describe what this change does.

Copilot AI commented Mar 10, 2026

Copy link
Copy Markdown
Contributor Author

Copilot update the PR description to describe which typos have been fixed. Don't say anything about things you didn't do, just describe what this change does.

Updated the PR description to focus only on the typos fixed by this PR.

Copilot AI changed the title Fix spelling errors Fix spelling errors detected by linux packaging tools Mar 10, 2026
@damyanp Damyan Pepper (damyanp) changed the title Fix spelling errors detected by linux packaging tools Fix spelling errors Mar 10, 2026
@damyanp
Damyan Pepper (damyanp) merged commit 13d6d44 into main Jul 7, 2026
23 checks passed
@github-project-automation github-project-automation Bot moved this from In progress to Done in HLSL Roadmap Jul 7, 2026
@damyanp
Damyan Pepper (damyanp) deleted the copilot/fix-typos-in-codebase branch July 7, 2026 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

6 participants