Skip static cbuffer variables in explicit layout indexing - #8538
Closed
Lucas (fall2019) wants to merge 1 commit into
Closed
Skip static cbuffer variables in explicit layout indexing#8538Lucas (fall2019) wants to merge 1 commit into
Lucas (fall2019) wants to merge 1 commit into
Conversation
Author
|
@microsoft-github-policy-service agree |
Author
|
/azp run |
|
Commenter does not have sufficient privileges for PR 8538 in repo microsoft/DirectXShaderCompiler |
Author
|
Helena Kotas (@hekota) Hello! Thanks for the approval. I don't have permission to trigger the Azure Pipelines. Could you run /azp so the checks can complete? Thanks! |
Member
|
Collaborator
|
A separate PR is a more complete fix of this issue (see #8731). The fix in this PR drops the static members, which isn't ideal, so we should take the other solution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes invalid SPIR-V generation when a
cbuffercontains interleavedstatic constdeclarations.Fixes #8537