[HLSL] Correct ShaderOp SRV resource states#8665
Draft
JoeCitizen wants to merge 2 commits into
Draft
Conversation
Use the shared MatrixUse parameter for the OuterProduct result and set it to Accumulator, matching proposal 0035 and the public dx::linalg API. Add a host-side invariant to prevent the legacy A-use declaration from returning. Assisted-by: GitHub Copilot Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 83725f5d-8e98-4c1d-91ee-ad47629e007b
Create SRV buffers without UAV flags and transition them for both pixel and non-pixel shader access. Use a direct resource-initialization list so the graphics-only pixel state is legal. Assisted-by: GitHub Copilot Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 83725f5d-8e98-4c1d-91ee-ad47629e007b
This was referenced Jul 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The resource-initialization list was previously compute-only. A compute list cannot transition a resource into
D3D12_RESOURCE_STATE_PIXEL_SHADER_RESOURCE, so the framework must use a direct list beforeaddSRVBuffercan advertise the complete SRV state.Validation
ExecHLSLTeststargetaddSRVBufferon WARP1.65535.20-previewwith D3D12 Agility SDK1.721.2-previewandExperimentalShaders=*ExecutionTest::BasicTriangleOpTestas a graphics ShaderOp framework regressionNo physical GPU or HLK lab execution is claimed.
Stack
This draft is stacked on PR #8662. Until that PR lands, this diff also contains its OuterProduct ancestor commit. The SRV change itself is commit
35d571e06.Refs #7841
Refs #8378
Assisted-by: GitHub Copilot