Skip CodeGenFloatingPointEnvironment under x64 ARM64 emulation - #8794
Open
Alex Sepkowski (alsepkow) wants to merge 2 commits into
Open
Skip CodeGenFloatingPointEnvironment under x64 ARM64 emulation#8794Alex Sepkowski (alsepkow) wants to merge 2 commits into
Alex Sepkowski (alsepkow) wants to merge 2 commits into
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: cf0be5dd-405f-45e0-897d-a4762fa7b920
Alex Sepkowski (alsepkow)
marked this pull request as ready for review
August 18, 2026 00:55
Alex Sepkowski (alsepkow)
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
Skips a Windows floating-point test when an x64 binary runs under ARM64 emulation, avoiding a known platform-specific false failure.
Changes:
- Dynamically detects ARM64 host architecture via
IsWow64Process2. - Reports the affected test as skipped under x64 emulation.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Damyan Pepper (damyanp)
approved these changes
Aug 18, 2026
Damyan Pepper (damyanp)
left a comment
Damyan Pepper (damyanp)
left a comment
Member
There was a problem hiding this comment.
Can you file a follow up bug to remind us to investigate this further please?
Contributor
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fixes #8793
Skip
CompilerTest::CodeGenFloatingPointEnvironmentwhen the x64 test binary is running under emulation on ARM64 Windows.The test attempts to unmask the divide-by-zero floating-point exception, but x64 emulation leaves
_EM_ZERODIVIDEmasked. The failure occurs before DXC compilation, so it does not indicate an ARM64X compiler regression.The runtime check uses the x64 target macro together with
IsWow64Process2's native machine result.IsWow64Process2is resolved dynamically to preserve compatibility with older Windows versions.The following PR's originally added skip logic for this test in 2022
#4308
#4320
Testing
Tested on ARM64 Windows with an x64 build of
ClangHLSLTests:CodeGenFloatingPointEnvironmentfailed with0x0208021Fversus0x02080217.4928total,4927passed,0failed,1skipped.