Added guard for 32-bit overflow in spritefont reading#627
Merged
Conversation
0932ba6 to
bc35137
Compare
nadaOuf
approved these changes
Apr 20, 2026
Member
Author
|
Resolves MSRC 113267 which is rated Moderate risk of Remote Code Execution. This is limited in practice as it's only 32-bit versions of the library -and- spritefont files are normally shipped with the app and not from untrusted third parties. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a potential overflow in the 32-bit version of the library when reading malicious spritefont files.