Add support for LoadFromEXRMemory as other formats#645
Merged
walbourn merged 5 commits intomicrosoft:mainfrom Mar 7, 2026
Merged
Add support for LoadFromEXRMemory as other formats#645walbourn merged 5 commits intomicrosoft:mainfrom
walbourn merged 5 commits intomicrosoft:mainfrom
Conversation
Member
|
Can you rebase this? |
vkaytsanov
force-pushed
the
EXRLoadFromMemory
branch
from
ba1573c to
cbb8f27
Compare
Contributor
Author
|
@walbourn rebased and rearranged the code a little bit to give better diff. Please note, that I haven't tested non-windows desktop systems for the template argument deduction |
walbourn
reviewed
Jan 20, 2026
walbourn
reviewed
Jan 20, 2026
walbourn
reviewed
Jan 20, 2026
|
Any plans to add support for loading mipmaps from tiled exrs? |
vkaytsanov
force-pushed
the
EXRLoadFromMemory
branch
from
b8094fa to
0654217
Compare
vkaytsanov
force-pushed
the
EXRLoadFromMemory
branch
from
0654217 to
2d2e93a
Compare
Fixed uninitialized data from getmetadata
walbourn
approved these changes
Mar 7, 2026
Member
Member
|
Thanks for your help! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tested from memory and from file the following exr: https://polyhaven.com/a/qwantani_dusk_2_puresky
Changes:
Rename *Stream -> *FileStream
Add InputStream wrapper to read from memory
Cut-paste the whole LoadFromEXRFile try-catch into LoadFromEXRCommon
Remove the equal sign from COMBINED_OPENEXR_VERSION as I am exactly on this version and I don't have this virtual method, todo: implement it in the future