Deyu/perf - #1280
Merged
Merged
Conversation
added 2 commits
July 28, 2026 16:30
test_full_mask_val's AVX2 fast path issues an unconditional 256-bit (4-word) load over the query mask, so every query bitmask buffer must be at least AVX2_TAIL_PADDING words long and fully zeroed -- otherwise stale high words (from a reused scratch buffer) or out-of-bounds reads (from a buffer sized to bitmask_size < 4) participate in the AND and produce false label matches. This corrupted both filtered search recall and filtered graph construction. - bitmask_filter_match::build_query_mask: single place that sizes and clears the query mask (clear + resize to >= AVX2_TAIL_PADDING), shared by both ctors. - aggregate_points_by_bitmask_label: pad + zero the per-label query mask (was sized to bitmask_size, under 4 words). - Add AVX2 correctness corner-case tests: single-word no-cross-point leak, reused-buffer re-zeroing, word-boundary labels, universal label, and large-size AVX2-block-plus-scalar-tail.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
What does this implement/fix? Briefly explain your changes.
Any other comments?