Skip to content

Fix Build - #1293

Merged
hildebrandmw merged 1 commit into
mainfrom
mhildebr/build-failure
Jul 29, 2026
Merged

Fix Build#1293
hildebrandmw merged 1 commit into
mainfrom
mhildebr/build-failure

Conversation

@hildebrandmw

Copy link
Copy Markdown
Contributor

Merge order woes between #1273 and #1206 resulted in main being broken. This fixes compilation.

@hildebrandmw
hildebrandmw requested review from a team and Copilot July 29, 2026 15:32

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR restores compilation on main after merge-order conflicts between PRs that refactored the Neighbor API and introduced the diskann-inmem provider, by updating call sites to the new accessor-based Neighbor interface and ensuring CI also builds the diskann-inmem integration-test configuration.

Changes:

  • Update diskann-inmem provider code to use Neighbor::id() / Neighbor::distance() accessors.
  • Update diskann-inmem integration index tests to use Neighbor::id() accessor.
  • Extend CI and nightly feature matrices to include the diskann-inmem integration-test feature so it is compiled in automation.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
diskann-inmem/src/provider.rs Fixes compilation against the updated Neighbor API during search post-processing.
diskann-inmem/integration/index/tests.rs Fixes integration index test compilation against the updated Neighbor API.
.github/workflows/nightly.yml Ensures nightly “all features” builds also compile the diskann-inmem integration-test configuration.
.github/workflows/ci.yml Ensures PR CI feature builds also compile the diskann-inmem integration-test configuration.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@hildebrandmw
hildebrandmw merged commit 3e7c1f3 into main Jul 29, 2026
27 of 28 checks passed
@hildebrandmw
hildebrandmw deleted the mhildebr/build-failure branch July 29, 2026 15:49
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.62%. Comparing base (a10433d) to head (5668982).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1293      +/-   ##
==========================================
- Coverage   91.49%   90.62%   -0.88%     
==========================================
  Files         497      512      +15     
  Lines       95548    98807    +3259     
==========================================
+ Hits        87423    89539    +2116     
- Misses       8125     9268    +1143     
Flag Coverage Δ
miri 90.62% <100.00%> (-0.88%) ⬇️
unittests 90.29% <100.00%> (-1.17%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
diskann-inmem/src/provider.rs 86.88% <100.00%> (ø)

... and 38 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants