Change all export * in package/framework to named exports#12424
Conversation
github-actions
Bot
added
area: framework
|
|
||
| export { AttachState } | ||
|
|
||
| export { CompressedSerializedInterval } |
There was a problem hiding this comment.
do we really need an export per type? can't they all be bundled into a single export statement?
There was a problem hiding this comment.
ahh. this is the mark down. blah.
There was a problem hiding this comment.
however, this file is insane. fyi @tylerbutler @Josmithr who i think know about docs
There was a problem hiding this comment.
we might want to consider keeping export * for this package, as they are all just re-exports.
There was a problem hiding this comment.
Yeah, it's just that this what gets generated by the api-extractor after I run "npm run build" after my script makes the changes to the ts files. I never directly touch the .md files!
There was a problem hiding this comment.
If I keep the export * in this file, the CI fails to build it.
ghoshkaj
force-pushed
the
named-export-package-framework
branch
from
20c6a26 to
09f8abe
Compare
ghoshkaj
force-pushed
the
named-export-package-framework
branch
from
09f8abe to
93ad7bc
Compare
…oft#12424) This PR converts `export *` in `package/framework` to named exports. Related issue: microsoft#10062 See for the fact that bundle size does not change when the entire repo is converted: microsoft#12321 (comment).
2 participants
This PR converts
export *inpackage/frameworkto named exports.Related issue: #10062
See for the fact that bundle size does not change when the entire repo is converted: #12321 (comment). I could not merge that PR because it is too large for one change and would make main-next integration a nightmare.