SharedString DDS annotateAdjustRange#22751
Merged
Merged
Conversation
…to prototype-deprecate-client
…to test/internal-merge-tree-client
…to seperate-segment-visabilty-interfaces
…to test/internal-merge-tree-client
…to test/remove-ISegment-deprecations
…to test/remove-ISegment-deprecations
…to test/remove-ISegment-deprecations
…to test/internal-merge-tree-client
…to test/merge-tree-adjust
…to test/merge-tree-adjust
…to test/merge-tree-adjust
…to test/merge-tree-adjust
anthony-murphy
commented
Nov 8, 2024
anthony-murphy
commented
Nov 8, 2024
9737ca0 to
3122f69
Compare
anthony-murphy
commented
Nov 8, 2024
…to test/merge-tree-adjust
anthony-murphy
added a commit
that referenced
this pull request
Nov 13, 2024
…nge (#23059) This change splits out the changes the PropertiesManger class from #22751. The goal is to supply a smaller set of changes that are easier to review, and allow #22751 to be checked in in two parts. After this all that will be left in #22751 is plumbing the feature through the layers. For the broader context of this change, please read the descriptions from: #22751 --------- Co-authored-by: Tyler Butler <tylerbu@microsoft.com> Co-authored-by: Abram Sanderson <Abram.sanderson@gmail.com>
…to test/merge-tree-adjust
anthony-murphy
commented
Nov 14, 2024
jzaffiro
reviewed
Nov 15, 2024
Contributor
jzaffiro
left a comment
There was a problem hiding this comment.
Changes look good to me, but I didn't have a chance to review the first PR so you may want a second opinion.
dbda8ea to
3a23e84
Compare
…/FluidFramework into test/merge-tree-adjust
3a23e84 to
272baba
Compare
Abe27342
approved these changes
Nov 15, 2024
jzaffiro
approved these changes
Nov 15, 2024
This was referenced Nov 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This update introduces a new feature to the
SharedStringDDS, allowing for the adjustment of properties over a specified range. TheannotateAdjustRangemethod enables users to apply adjustments to properties within a given range, providing more flexibility and control over property modifications.An adjustment is a modification applied to a property value within a specified range. Adjustments can be used to increment or decrement property values dynamically. They are particularly useful in scenarios where property values need to be updated based on user interactions or other events. For example, in a rich text editor, adjustments can be used for modifying indentation levels or font sizes, where multiple users could apply differing numerical adjustments.
Key Features and Use Cases:
Configuration and Compatibility Requirements:
This feature is only available when the configuration
Fluid.Sequence.mergeTreeEnableAnnotateAdjustis set totrue. Additionally, all collaborating clients must have this feature enabled to use it. If any client does not have this feature enabled, it will lead to the client exiting collaboration. A future major version of Fluid will enable this feature by default.Usage Example:
AB#11819