PropertiesManager Update to Support SharedString DDS annotateAdjustRange#23059
Merged
anthony-murphy merged 162 commits intoNov 13, 2024
Merged
Conversation
…to prototype-deprecate-client
…to test/internal-merge-tree-client
…to seperate-segment-visabilty-interfaces
…to test/internal-merge-tree-client
…to test/remove-ISegment-deprecations
…to test/remove-ISegment-deprecations
…to test/remove-ISegment-deprecations
…to test/internal-merge-tree-client
…to test/merge-tree-adjust
…to test/merge-tree-adjust
…to test/merge-tree-adjust
…to test/merge-tree-adjust
…to test/merge-tree-adjust
github-actions
Bot
added
base: main
anthony-murphy
commented
Nov 12, 2024
| @@ -3,13 +3,16 @@ | |||
| * Licensed under the MIT License. | |||
Contributor
Author
There was a problem hiding this comment.
this file contains most of the important changes, and is essentially a rewrite. i recommend reviewing in split view, rather than inline diff, as the changes are not incremental, so inline diffs will not make very much sense.
anthony-murphy
force-pushed
the
just-pending-state-manager
branch
from
df5d68a to
77d1afe
Compare
github-actions
Bot
removed
the
area: framework
msfluid-bot
reviewed
Nov 12, 2024
Collaborator
There was a problem hiding this comment.
Code Coverage Summary
↓ packages.dds.merge-tree.src:
Line Coverage Change: 0.05% Branch Coverage Change: -0.16%
| Metric Name | Baseline coverage | PR coverage | Coverage Diff |
|---|---|---|---|
| Branch Coverage | 94.94% | 94.78% | ↓ -0.16% |
| Line Coverage | 97.27% | 97.32% | ↑ 0.05% |
↑ packages.dds.sequence.src:
Line Coverage Change: No change Branch Coverage Change: 0.13%
| Metric Name | Baseline coverage | PR coverage | Coverage Diff |
|---|---|---|---|
| Branch Coverage | 89.53% | 89.66% | ↑ 0.13% |
| Line Coverage | 89.87% | 89.87% | → No change |
↑ packages.dds.merge-tree.src.collections:
Line Coverage Change: 0.21% Branch Coverage Change: 0.17%
| Metric Name | Baseline coverage | PR coverage | Coverage Diff |
|---|---|---|---|
| Branch Coverage | 91.49% | 91.66% | ↑ 0.17% |
| Line Coverage | 93.69% | 93.90% | ↑ 0.21% |
Baseline commit: 861bc29
Baseline build: 306341
Happy Coding!!
Code coverage comparison check passed!!
Collaborator
⯅ @fluid-example/bundle-size-tests: +4.77 KB
Baseline commit: cc3fb6d |
Contributor
There was a problem hiding this comment.
Copilot reviewed 5 out of 12 changed files in this pull request and generated no suggestions.
Files not reviewed (7)
- packages/dds/merge-tree/package.json: Language not supported
- packages/dds/merge-tree/api-report/merge-tree.legacy.alpha.api.md: Evaluated as low risk
- packages/dds/merge-tree/src/collections/index.ts: Evaluated as low risk
- packages/dds/merge-tree/src/ops.ts: Evaluated as low risk
- packages/dds/merge-tree/src/segmentPropertiesManager.ts: Evaluated as low risk
- packages/dds/merge-tree/src/index.ts: Evaluated as low risk
- packages/dds/merge-tree/src/mergeTree.ts: Evaluated as low risk
Tip: Copilot only keeps its highest confidence comments to reduce noise and keep you focused. Learn more
Abe27342
reviewed
Nov 12, 2024
Contributor
Abe27342
left a comment
Abe27342
left a comment
There was a problem hiding this comment.
looks pretty good, few smallish pieces of feedback
| const change = this.changes.get(key); | ||
| const acked = change?.local?.shift(); | ||
| assert(change !== undefined && acked !== undefined, "must have local change to ack"); | ||
| // we only track remotes if there are adjusts, as only adjusts make application anti-commutative |
Contributor
There was a problem hiding this comment.
nice optimization, was pondering if the known issues we have around zamboni not being as active as it should would be problematic, but this should avoid that for the cases we care most about for now :)
Contributor
Author
There was a problem hiding this comment.
Yeah. i waffled on this a bit. I think it is fine for now, as i don't foresee these lists getting very big, and they only cost anything when changes are applied, and when there are changes, they get cleaned up. There might be some that sit around when they don't need to, but when we fix zamboni, this should also get resolved.
Co-authored-by: Abram Sanderson <Abram.sanderson@gmail.com>
Co-authored-by: Abram Sanderson <Abram.sanderson@gmail.com>
…to just-pending-state-manager
Abe27342
approved these changes
Nov 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change splits out the changes the PropertiesManger class from #22751. The goal is to supply a smaller set of changes that are easier to review, and allow #22751 to be checked in in two parts. After this all that will be left in #22751 is plumbing the feature through the layers.
For the broader context of this change, please read the descriptions from: #22751