Save obliterate sequence number on zero-length obliterates#23011
Merged
Conversation
msfluid-bot
reviewed
Nov 6, 2024
Collaborator
There was a problem hiding this comment.
Code Coverage Summary
↑ packages.dds.sequence.src:
Line Coverage Change: 0.02% Branch Coverage Change: 0.05%
| Metric Name | Baseline coverage | PR coverage | Coverage Diff |
|---|---|---|---|
| Branch Coverage | 89.48% | 89.53% | ↑ 0.05% |
| Line Coverage | 89.85% | 89.87% | ↑ 0.02% |
Baseline commit: 5156eb4
Baseline build: 305838
Happy Coding!!
Code coverage comparison check passed!!
Contributor
There was a problem hiding this comment.
Copilot reviewed 2 out of 2 changed files in this pull request and generated no suggestions.
Comments skipped due to low confidence (3)
packages/dds/merge-tree/src/mergeTree.ts:1253
- Ensure there are tests that cover scenarios where
obliterateInfois undefined.
if (pendingSegmentGroup.obliterateInfo !== undefined) {
packages/dds/merge-tree/src/mergeTree.ts:2108
- Ensure there are tests that cover scenarios where the start and end positions or sides are equal.
if (start.pos !== end.pos || start.side !== end.side) {
packages/dds/merge-tree/src/mergeTreeNodes.ts:706
- The assignment to
obliterateInfo.seqhas been removed. IfobliterateInfo.seqis used elsewhere, this could introduce a bug. EnsureobliterateInfo.seqis set correctly.
moveInfo.movedSeqs[seqIdx] = opArgs.sequencedMessage!.sequenceNumber;
Tip: Copilot only keeps its highest confidence comments to reduce noise and keep you focused. Learn more
This reverts commit 18f0826.
anthony-murphy
approved these changes
Nov 11, 2024
Contributor
Author
|
@anthony-murphy I had to merge the sequence changes into this PR because there were two tests failing on assert 0x2d8. |
Collaborator
⯅ @fluid-example/bundle-size-tests: +475 Bytes
Baseline commit: 3c27751 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes how we save the obliterate sequence number on the associated
pendingSegmentGroup. Previously, the sequence number would never be set for zero-length obliterates, so we would get stuck considering the obliterate as unsequenced.This PR also surfaces zero-length obliterates in
mergeTreeDeltaCallbackas long as the obliterate's endpoints are not equal.