Sequence zero length obliterate fix#23012
Closed
titrindl wants to merge 7 commits into
Closed
Conversation
github-actions
Bot
added
area: dds
msfluid-bot
reviewed
Nov 6, 2024
Collaborator
msfluid-bot
left a comment
msfluid-bot
left a comment
There was a problem hiding this comment.
Code Coverage Summary
↑ packages.dds.sequence.src:
Line Coverage Change: 0.01% Branch Coverage Change: 0.03%
| Metric Name | Baseline coverage | PR coverage | Coverage Diff |
|---|---|---|---|
| Branch Coverage | 89.44% | 89.47% | ↑ 0.03% |
| Line Coverage | 89.83% | 89.84% | ↑ 0.01% |
Baseline commit: 85d0e82
Baseline build: 304645
Happy Coding!!
Code coverage comparison check passed!!
Collaborator
⯅ @fluid-example/bundle-size-tests: +432 Bytes
Baseline commit: 85d0e82 |
Contributor
There was a problem hiding this comment.
Copilot reviewed 4 out of 4 changed files in this pull request and generated no suggestions.
Tip: Copilot only keeps its highest confidence comments to reduce noise and keep you focused. Learn more
anthony-murphy
approved these changes
Nov 8, 2024
Contributor
Author
|
Merged into #23011 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Guard assert on
deltaArgs.deltaSegments.lengthinSequenceEventto allow zero length obliterates. An obliterate can still have an effect on concurrent inserts even if it affects zero segments when it is sequenced.