Skip to content

More more settings to workspace files - #27614

Merged
Craig Macomber (Microsoft) (CraigMacomber) merged 3 commits into
microsoft:mainfrom
CraigMacomber:MoreWorkspace
Jun 29, 2026
Merged

More more settings to workspace files#27614
Craig Macomber (Microsoft) (CraigMacomber) merged 3 commits into
microsoft:mainfrom
CraigMacomber:MoreWorkspace

Conversation

@CraigMacomber

Copy link
Copy Markdown
Contributor

Description

More settings to pnpm-workspace where possible. Reduces diff needed to move to pnpm 11.

Changes split out from #27510

Reviewer Guidance

The review process is outlined on this wiki page.

@github-actions

github-actions Bot commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

Hi! Thank you for opening this PR. Want me to review it?

Based on the diff (522 lines, 17 files), I've queued these reviewers:

  • Correctness — logic errors, race conditions, lifecycle issues
  • Security — vulnerabilities, secret exposure, injection
  • API Compatibility — breaking changes, release tags, type design
  • Performance — algorithmic regressions, memory leaks
  • Testing — coverage gaps, hollow tests

How this works

  • Adjust the reviewer set by ticking/unticking boxes above. Reviewer toggles alone don't trigger anything.

  • Tick Start review below to dispatch the review fleet.

  • After review finishes, tick Start review again to request another run — it auto-resets after each dispatch.

  • This comment updates as new commits land; your reviewer selections are preserved.

  • Start review

@CraigMacomber
Craig Macomber (Microsoft) (CraigMacomber) marked this pull request as ready for review June 29, 2026 18:58
Copilot AI review requested due to automatic review settings June 29, 2026 18:58

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 17 out of 17 changed files in this pull request and generated no comments.

@github-actions

Copy link
Copy Markdown
Contributor

Bundle size comparison

Base commit: 83f341cb4e76e4a7438a31a486fb317fb8a3e2e3
Head commit: c49580064cf4e8437db626822b0b3ffaf85666ca

Notable changes

No bundles changed by ≥ 500 bytes parsed.

Per-bundle deltas

@fluid-example/bundle-size-tests

  • azureClient.js: parsed 619057 → 619113 (+56), gzip 164811 → 164859 (+48)
  • odspClient.js: parsed 591891 → 591947 (+56), gzip 158905 → 158948 (+43)
  • aqueduct.js: parsed 525587 → 525622 (+35), gzip 140709 → 140740 (+31)
  • fluidFramework.js: parsed 392450 → 392471 (+21), gzip 111413 → 111429 (+16)
  • sharedTree.js: parsed 381837 → 381851 (+14), gzip 108807 → 108817 (+10)
  • containerRuntime.js: parsed 303937 → 303951 (+14), gzip 83213 → 83222 (+9)
  • sharedString.js: parsed 175984 → 175991 (+7), gzip 49445 → 49453 (+8)
  • experimentalSharedTree.js: parsed 160798 → 160798 (0), gzip 45804 → 45804 (0)
  • matrix.js: parsed 159845 → 159852 (+7), gzip 45411 → 45418 (+7)
  • loader.js: parsed 145221 → 145235 (+14), gzip 39052 → 39067 (+15)
  • odspDriver.js: parsed 104431 → 104452 (+21), gzip 32647 → 32657 (+10)
  • directory.js: parsed 66616 → 66623 (+7), gzip 18532 → 18540 (+8)
  • 748.js: parsed 58793 → 58793 (0), gzip 17826 → 17826 (0)
  • map.js: parsed 46709 → 46716 (+7), gzip 14310 → 14317 (+7)
  • odspPrefetchSnapshot.js: parsed 45650 → 45664 (+14), gzip 15275 → 15284 (+9)
  • 594.js: parsed 44493 → 44493 (0), gzip 13744 → 13744 (0)
  • summarizerDelayLoadedModule.js: parsed 30753 → 30753 (0), gzip 7767 → 7767 (0)
  • socketModule.js: parsed 26486 → 26493 (+7), gzip 7883 → 7891 (+8)
  • createNewModule.js: parsed 12480 → 12480 (0), gzip 4786 → 4786 (0)
  • summaryModule.js: parsed 3797 → 3797 (0), gzip 1860 → 1860 (0)
  • connectionState.js: parsed 724 → 724 (0), gzip 429 → 429 (0)
  • sharedTreeAttributes.js: parsed 666 → 673 (+7), gzip 432 → 442 (+10)
  • debugAssert.js: parsed 429 → 429 (0), gzip 299 → 299 (0)
  • FluidFramework-HashFallback.js: parsed 422 → 422 (0), gzip 316 → 316 (0)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OMG real comments!

@CraigMacomber

Copy link
Copy Markdown
Contributor Author

OMG real comments!

That's my favorite part :)

@CraigMacomber
Craig Macomber (Microsoft) (CraigMacomber) merged commit 899d218 into microsoft:main Jun 29, 2026
62 checks passed
brrichards pushed a commit to brrichards/FluidFramework that referenced this pull request Jun 30, 2026
## Description

More settings to pnpm-workspace where possible. Reduces diff needed to
move to pnpm 11.

Changes split out from
microsoft#27510
Craig Macomber (Microsoft) (CraigMacomber) added a commit that referenced this pull request Jun 30, 2026
## Description

Continuation of #27614
to the tools directory.
Craig Macomber (Microsoft) (CraigMacomber) added a commit that referenced this pull request Jun 30, 2026
## Description

Continuation of #27614 to the server directory.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants