Skip to content

git ignore .npmrc - #27620

Merged
Craig Macomber (Microsoft) (CraigMacomber) merged 4 commits into
microsoft:mainfrom
CraigMacomber:ignore-npmrc
Jul 1, 2026
Merged

git ignore .npmrc#27620
Craig Macomber (Microsoft) (CraigMacomber) merged 4 commits into
microsoft:mainfrom
CraigMacomber:ignore-npmrc

Conversation

@CraigMacomber

Copy link
Copy Markdown
Contributor

Description

git ignore .npmrc

Reviewer Guidance

The review process is outlined on this wiki page.

@github-actions

github-actions Bot commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

Hi! Thank you for opening this PR. Want me to review it?

Based on the diff (5 lines, 2 files), I've queued these reviewers:

  • Correctness — logic errors, race conditions, lifecycle issues
  • Security — vulnerabilities, secret exposure, injection
  • API Compatibility — breaking changes, release tags, type design
  • Performance — algorithmic regressions, memory leaks
  • Testing — coverage gaps, hollow tests

How this works

  • Adjust the reviewer set by ticking/unticking boxes above. Reviewer toggles alone don't trigger anything.

  • Tick Start review below to dispatch the review fleet.

  • After review finishes, tick Start review again to request another run — it auto-resets after each dispatch.

  • This comment updates as new commits land; your reviewer selections are preserved.

  • Start review

@@ -1 +0,0 @@
node-linker=isolated

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the default for this setting (see https://pnpm.io/settings#nodelinker ) so it does nothing. Thus can safely be removed, removing the last versioned npmrc file.

@CraigMacomber
Craig Macomber (Microsoft) (CraigMacomber) marked this pull request as ready for review July 1, 2026 16:32
Copilot AI review requested due to automatic review settings July 1, 2026 16:32

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.

@github-actions

github-actions Bot commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Bundle size comparison

Base commit: 9e445ef72e70d45002ea1ad74bcf8949a12add11
Head commit: 8379e12ad73c9261796ab1650c546a8bb5e3e883

Notable changes

No bundles changed by ≥ 500 bytes parsed.

Per-bundle deltas

@fluid-example/bundle-size-tests

  • azureClient.js: parsed 619063 → 619119 (+56), gzip 164813 → 164860 (+47)
  • odspClient.js: parsed 591789 → 591845 (+56), gzip 158906 → 158949 (+43)
  • aqueduct.js: parsed 525587 → 525622 (+35), gzip 140709 → 140740 (+31)
  • fluidFramework.js: parsed 393001 → 393022 (+21), gzip 111618 → 111634 (+16)
  • sharedTree.js: parsed 382388 → 382402 (+14), gzip 109007 → 109016 (+9)
  • containerRuntime.js: parsed 303937 → 303951 (+14), gzip 83213 → 83222 (+9)
  • sharedString.js: parsed 175984 → 175991 (+7), gzip 49445 → 49453 (+8)
  • experimentalSharedTree.js: parsed 160798 → 160798 (0), gzip 45804 → 45804 (0)
  • matrix.js: parsed 159845 → 159852 (+7), gzip 45411 → 45418 (+7)
  • loader.js: parsed 145221 → 145235 (+14), gzip 39052 → 39067 (+15)
  • odspDriver.js: parsed 104329 → 104350 (+21), gzip 32649 → 32659 (+10)
  • directory.js: parsed 66616 → 66623 (+7), gzip 18532 → 18540 (+8)
  • 748.js: parsed 58793 → 58793 (0), gzip 17826 → 17826 (0)
  • map.js: parsed 46709 → 46716 (+7), gzip 14310 → 14318 (+8)
  • odspPrefetchSnapshot.js: parsed 45642 → 45656 (+14), gzip 15276 → 15285 (+9)
  • 594.js: parsed 44493 → 44493 (0), gzip 13744 → 13744 (0)
  • summarizerDelayLoadedModule.js: parsed 30753 → 30753 (0), gzip 7767 → 7767 (0)
  • socketModule.js: parsed 26477 → 26484 (+7), gzip 7885 → 7894 (+9)
  • createNewModule.js: parsed 12480 → 12480 (0), gzip 4786 → 4786 (0)
  • summaryModule.js: parsed 3797 → 3797 (0), gzip 1860 → 1860 (0)
  • connectionState.js: parsed 724 → 724 (0), gzip 429 → 429 (0)
  • sharedTreeAttributes.js: parsed 666 → 673 (+7), gzip 432 → 442 (+10)
  • debugAssert.js: parsed 429 → 429 (0), gzip 299 → 299 (0)
  • FluidFramework-HashFallback.js: parsed 422 → 422 (0), gzip 316 → 316 (0)

@CraigMacomber
Craig Macomber (Microsoft) (CraigMacomber) merged commit b17b7e6 into microsoft:main Jul 1, 2026
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants