Skip to content

Example Webpack config cleanup and deduplication - #27657

Merged
Craig Macomber (Microsoft) (CraigMacomber) merged 3 commits into
microsoft:mainfrom
CraigMacomber:webpackCleanup
Jul 9, 2026
Merged

Example Webpack config cleanup and deduplication#27657
Craig Macomber (Microsoft) (CraigMacomber) merged 3 commits into
microsoft:mainfrom
CraigMacomber:webpackCleanup

Conversation

@CraigMacomber

@CraigMacomber Craig Macomber (Microsoft) (CraigMacomber) commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Description

I don't think we really any anyone making apps based on copying these "examples" so I don't think there is much value in making the webpack settings we recommend clear inline in every single webpack config, especially given they already use our example utils which external apps shouldn't. Centralizing them makes maintaining them easier.

Reviewer Guidance

The review process is outlined on this wiki page.

Copilot AI review requested due to automatic review settings July 8, 2026 20:38
@CraigMacomber Craig Macomber (Microsoft) (CraigMacomber) changed the title Webpack cleanup Example Webpack config cleanup and deduplication Jul 8, 2026
@github-actions

github-actions Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Hi! Thank you for opening this PR. Want me to review it?

Based on the diff (1099 lines, 32 files), I've queued these reviewers:

  • Correctness — logic errors, race conditions, lifecycle issues
  • Security — vulnerabilities, secret exposure, injection
  • API Compatibility — breaking changes, release tags, type design
  • Performance — algorithmic regressions, memory leaks
  • Testing — coverage gaps, hollow tests

How this works

  • Adjust the reviewer set by ticking/unticking boxes above. Reviewer toggles alone don't trigger anything.

  • Tick Start review below to dispatch the review fleet.

  • After review finishes, tick Start review again to request another run — it auto-resets after each dispatch.

  • This comment updates as new commits land; your reviewer selections are preserved.

  • Start review

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 31 out of 32 changed files in this pull request and generated no comments.

Files not reviewed (1)
  • pnpm-lock.yaml: Generated file

@github-actions

github-actions Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Bundle size comparison

Base commit: 541fb974a8c83efc941264c28cba4278b3eb7f39
Head commit: ac4db3da1952bd049f0ee0e4bbea08387ed1e366

Notable changes

No bundles changed by ≥ 500 bytes parsed.

Per-bundle deltas

@fluid-example/bundle-size-tests

  • azureClient.js: parsed 619098 → 619154 (+56), gzip 164826 → 164873 (+47)
  • odspClient.js: parsed 591824 → 591880 (+56), gzip 158912 → 158955 (+43)
  • aqueduct.js: parsed 525587 → 525622 (+35), gzip 140710 → 140738 (+28)
  • fluidFramework.js: parsed 392824 → 392845 (+21), gzip 111523 → 111540 (+17)
  • sharedTree.js: parsed 382211 → 382225 (+14), gzip 108913 → 108924 (+11)
  • containerRuntime.js: parsed 303937 → 303951 (+14), gzip 83213 → 83222 (+9)
  • sharedString.js: parsed 175984 → 175991 (+7), gzip 49445 → 49453 (+8)
  • experimentalSharedTree.js: parsed 160798 → 160798 (0), gzip 45804 → 45804 (0)
  • matrix.js: parsed 159845 → 159852 (+7), gzip 45411 → 45418 (+7)
  • loader.js: parsed 145256 → 145270 (+14), gzip 39063 → 39077 (+14)
  • odspDriver.js: parsed 104329 → 104350 (+21), gzip 32646 → 32656 (+10)
  • directory.js: parsed 66616 → 66623 (+7), gzip 18532 → 18541 (+9)
  • 748.js: parsed 58793 → 58793 (0), gzip 17827 → 17827 (0)
  • map.js: parsed 46709 → 46716 (+7), gzip 14310 → 14318 (+8)
  • odspPrefetchSnapshot.js: parsed 45642 → 45656 (+14), gzip 15277 → 15285 (+8)
  • 985.js: parsed 44491 → 44491 (0), gzip 13726 → 13726 (0)
  • summarizerDelayLoadedModule.js: parsed 30749 → 30749 (0), gzip 7753 → 7753 (0)
  • socketModule.js: parsed 26476 → 26483 (+7), gzip 7885 → 7893 (+8)
  • createNewModule.js: parsed 12480 → 12480 (0), gzip 4786 → 4786 (0)
  • summaryModule.js: parsed 3797 → 3797 (0), gzip 1860 → 1860 (0)
  • connectionState.js: parsed 724 → 724 (0), gzip 429 → 429 (0)
  • sharedTreeAttributes.js: parsed 666 → 673 (+7), gzip 432 → 442 (+10)
  • debugAssert.js: parsed 429 → 429 (0), gzip 299 → 299 (0)
  • FluidFramework-HashFallback.js: parsed 422 → 422 (0), gzip 316 → 316 (0)

@CraigMacomber
Craig Macomber (Microsoft) (CraigMacomber) merged commit 3d579f3 into microsoft:main Jul 9, 2026
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants