Rename minVersionForCollab to oldestSupportedClient - #27806
Open
WillieHabi wants to merge 1 commit into
Open
Conversation
github-actions
Bot
added
area: framework
Contributor
|
Hi! Thank you for opening this PR. Want me to review it? Based on the diff (188 lines, 14 files), I've queued these reviewers:
How this works
|
WillieHabi
force-pushed
the
wh/oldest-supported-client
branch
from
July 31, 2026 17:25
c99ae9d to
560718b
Compare
github-actions
Bot
removed
area: dds
WillieHabi
force-pushed
the
wh/oldest-supported-client
branch
3 times, most recently
from
July 31, 2026 18:37
afe2544 to
04f8085
Compare
github-actions
Bot
added
the
area: tests
WillieHabi
marked this pull request as ready for review
July 31, 2026 20:38
Adopts the name sanctioned by the Fluid Framework API review thread: `oldestSupportedClient`, typed `OldestSupportedClientVersion`. - `MinimumVersionForCollab` -> `OldestSupportedClientVersion`, with the old name kept as a deprecated alias so existing references keep compiling. - `LoadContainerRuntimeParams.minVersionForCollab` -> `oldestSupportedClient`, old name deprecated, both-specified rejected. - `BaseContainerRuntimeFactoryProps.minVersionForCollab` -> `oldestSupportedClient`, same treatment. The name is deliberately layer-neutral. This value propagates through the Runtime and DataStore layers and is consumed by DDSes such as SharedTree for format and feature selection, so a runtime-scoped name would misrepresent the contract -- the objection that closed microsoft#27726. Renaming the internal propagation path is a separate mechanical follow-up. Persisted document-schema fields and telemetry property names are intentionally unchanged. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 06fbfc68-87c1-4ea2-ae5e-be0ac9a9ef39
WillieHabi
force-pushed
the
wh/oldest-supported-client
branch
from
July 31, 2026 21:26
04f8085 to
0266ebf
Compare
Contributor
|
🔗 No broken links found! ✅ Your attention to detail is admirable. linkcheck output |
Contributor
Bundle size comparisonBase commit: Notable changesNo bundles changed by ≥ 500 bytes parsed. Per-bundle deltas
|
Contributor
|
wait for #27824 to merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds
oldestSupportedClient, typedOldestSupportedClientVersion, as the preferred name for configuring container-runtime cross-client compatibility, while preserving compatibility withminVersionForCollab:MinimumVersionForCollab→OldestSupportedClientVersionLoadContainerRuntimeParams.minVersionForCollab→oldestSupportedClientBaseContainerRuntimeFactoryProps.minVersionForCollab→oldestSupportedClientThe old property names still work, marked
@deprecatedand specifying both throws aUsageError.MinimumVersionForCollabremains supported and is not deprecated in this PR: the deprecation checklist requires in-codebase uses to be removed at the same time, so the tag lands with that migration. Persisted document-schema fields and telemetry property names are unchanged.Tree, datastore, service-client, and test-utility APIs are intentionally out of scope.
Reviewer Guidance
The review process is outlined on this wiki page.