fix: preserve BubbleBench container compatibility - #27928
Merged
Conversation
Use Fluid-owned iterable contracts and a minimal read-only bubble collection so both SharedTree arrays and native arrays satisfy BubbleBench's shared model types. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
github-actions
Bot
added
area: examples
Contributor
|
Hi! Thank you for opening this PR. Want me to review it? Based on the diff (23 lines, 4 files), I've queued these reviewers:
How this works
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates BubbleBench’s shared types and container adapters to use FluidIterable and a minimal “bubble collection” contract, keeping the benchmark compatible with both Fluid Tree array nodes and native JavaScript arrays without requiring full Array semantics.
Changes:
- Introduces a minimal
ReadonlyBubbleCollectioncontract forIClient.bubblesand switchesIAppState.clientstoFluidIterable. - Updates the OT, experimental-tree, and shared-tree adapters to expose
clientsasFluidIterable. - Adds a standalone (no-package) changeset documenting the compatibility fix for release notes.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| examples/benchmarks/bubblebench/shared-tree/src/appState.ts | Updates clients to return FluidIterable for compatibility with Tree arrays. |
| examples/benchmarks/bubblebench/ot/src/state.ts | Adjusts the array-ish adapter contract to use FluidIterable instead of Iterable. |
| examples/benchmarks/bubblebench/experimental-tree/src/state.ts | Updates clients to FluidIterable to align with the shared contract. |
| examples/benchmarks/bubblebench/common/src/types.ts | Introduces ReadonlyBubbleCollection and switches clients to FluidIterable in the shared types. |
| .changeset/preserve-bubblebench-container-compatibility.md | Adds a no-package changeset entry documenting the fix in release notes. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Contributor
Bundle size comparisonBase commit: Notable changesNo bundles changed by ≥ 500 bytes parsed. Per-bundle deltas
|
Joshua Smithrud (Josmithr)
approved these changes
Aug 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
BubbleBench needs to support both Fluid Tree arrays and native arrays. This PR introduces a minimal shared collection contract so the benchmark remains compatible with both container implementations without requiring the full built-in array interface.
This is an internal-only change to private BubbleBench packages, so it does not include a changeset.
Validation performed:
git diff --check upstream/main...HEADbuild:compilefor all five BubbleBench packages:common,baseline,ot,experimental-tree, andshared-treeot,experimental-tree, andshared-tree(all passed)Reviewer Guidance
The review process is outlined on this wiki page.
The diff is limited to the shared BubbleBench collection type and its three Tree/OT adapters.