Skip to content

Fix git ls-files parsing across partial stream reads - #168

Merged
David Federman (dfederm) merged 2 commits into
microsoft:mainfrom
Evangelink:dev/amauryleve/fix-git-output-parsing
Aug 6, 2026
Merged

Fix git ls-files parsing across partial stream reads#168
David Federman (dfederm) merged 2 commits into
microsoft:mainfrom
Evangelink:dev/amauryleve/fix-git-output-parsing

Conversation

@Evangelink

@Evangelink Amaury Levé (Evangelink) commented Aug 6, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Summary

  • bound NUL delimiter searches to the valid portion of each TextReader read
  • reconstruct records exactly when staging metadata, paths, and delimiters span partial reads
  • preserve the existing producer/consumer reader architecture and record-size policy
  • add deterministic chunked-reader tests, including the 4095-character buffer edge

Validation

  • GitFileHashProviderTests: 11/11 passed on net9.0
  • GitFileHashProviderTests: 11/11 passed on net472
  • full Common test suite: 139/139 passed on net9.0

Closes #166

@Evangelink
Fix git ls-files partial read parsing
5829a04 
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@azure-pipelines

azure-pipelines Bot commented Aug 6, 2026

Copy link
Copy Markdown
Azure Pipelines:
There may be pipelines that require an authorized user to comment /azp run to run.

dfederm
David Federman (dfederm) reviewed Aug 6, 2026
View reviewed changes
Comment thread src/Common/SourceControl/GitFileHashProvider.cs
@Evangelink
Narrow git output parsing fix
639e256 
Preserve the existing producer-consumer reader while bounding NUL scans to valid data and fixing partial-record carry-over.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@dfederm

David Federman (dfederm) commented Aug 6, 2026

Copy link
Copy Markdown
Member

/azp run

@azure-pipelines

azure-pipelines Bot commented Aug 6, 2026

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 1 pipeline(s).

@dfederm
David Federman (dfederm) merged commit 647a056 into microsoft:main Aug 6, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dfederm David Federman (dfederm) dfederm approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Fix git ls-files parsing across partial stream reads

2 participants

@Evangelink @dfederm