Skip to content

Magnifier Render Feature Order Control#166

Merged
Cameron-Micka merged 29 commits intomicrosoft:mainfrom
Cameron-Micka:user/cameron-micka/magnifier-render-feature
Apr 7, 2023
Merged

Magnifier Render Feature Order Control#166
Cameron-Micka merged 29 commits intomicrosoft:mainfrom
Cameron-Micka:user/cameron-micka/magnifier-render-feature

Conversation

@Cameron-Micka
Copy link
Copy Markdown
Member

Overview

Adding the ability to control the sort order when adding magnifier render features (and remove their addition all together).

  • Sneaking in a fix to the material restore logic for a strange edge case.

Changes

Verification

This optional section is a place where you can detail the specific type of verification
you want from reviewers. For example, if you want reviewers to checkout the PR locally
and validate the functionality of specific scenarios, provide instructions
on the specific scenarios and what you want verified.

If there are specific areas of concern or question feel free to highlight them here so
that reviewers can watch out for those issues.

As a reviewer, it is possible to check out this change locally by using the following
commands (substituting {PR_ID} with the ID of this pull request):

git fetch origin pull/{PR_ID}/head:name_of_local_branch

git checkout name_of_local_branch

@Cameron-Micka Cameron-Micka merged commit 32f7b36 into microsoft:main Apr 7, 2023
Copy link
Copy Markdown
Contributor

@breezinstein breezinstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants