Skip to content

Magnifier#94

Merged
Cameron-Micka merged 58 commits intomicrosoft:mainfrom
ChuksOk:magnifier
Dec 13, 2022
Merged

Magnifier#94
Cameron-Micka merged 58 commits intomicrosoft:mainfrom
ChuksOk:magnifier

Conversation

@ChuksOk
Copy link
Copy Markdown
Contributor

@ChuksOk ChuksOk commented Aug 26, 2022

Overview

A custom render feature for the URP that works somewhat like Unity’s “grab pass” feature to help magnify the screen in stereo rendering contexts.
Magnifier

Motivation

In reference to #66 this is an accessibility tool akin to the Magnifier in SeeingVR to Make Virtual Reality More Accessible to People with Low Vision

ChuksOk and others added 15 commits June 9, 2022 19:10
Testing magnification
Tried Experimenting with HLSL instead of CG based off the fullscreen ColorBlit example, still doesn't work in URP or single pass instance rendering
I've managed to perform a fullscreen blit in multi pass , got single pass instance working in the editor, but for some reason it doesn't work in playmode like multi pass
mtest scene
New progress on the magnifier test shader, with the center and magification amounts exposed as public variables for easy manipulation
I've deleted most of the experimental stuff to avoid confusion
scene update with XR interaction toolkit
… but not without issues currently trying to find an alternative to bliting for XR

URP Grabpass for XR
new changes
@Cameron-Micka
Copy link
Copy Markdown
Member

Thank you for posting the draft! Would you be able to remove/clean up the files which don't need to be reviewed? For example, these files don't need to be checked in:
image

There might be some things we need to add to our gitignore. 😅

Comment thread com.microsoft.mrtk.graphicstools.unity/Runtime/Utilities/DrawFullscreenFeature.cs Outdated
Comment thread com.microsoft.mrtk.graphicstools.unity/Runtime/Utilities/DrawFullscreenPass.cs Outdated
@pinkwerks
Copy link
Copy Markdown
Contributor

pinkwerks commented Oct 10, 2022

I see there are Samples~, but they are not showing up in the Package Manager.
image

You can add your entry here:
https://github.com/microsoft/MixedReality-GraphicsTools-Unity/blob/main/com.microsoft.mrtk.graphicstools.unity/package.json

@pinkwerks
Copy link
Copy Markdown
Contributor

pinkwerks commented Oct 10, 2022

In the sample scene.... seeing some stretching of the zoomed content when resizing the game window. Also some magenta shaders....
Animation

Copy link
Copy Markdown
Member

@Cameron-Micka Cameron-Micka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going to pull down and test now. Looking good, most comments are about reverting files that may have been accidentally committed.

GraphicsSettings:
m_ObjectHideFlags: 0
serializedVersion: 14
serializedVersion: 13
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I bet this entire file could be reverted since you likely didn't mean to change the render pipeline we point to be default?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Comment thread com.microsoft.mrtk.graphicstools.unity/package.json Outdated
Comment thread com.microsoft.mrtk.graphicstools.unity/Samples.meta
Copy link
Copy Markdown
Member

@Cameron-Micka Cameron-Micka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Tested together.

@Cameron-Micka Cameron-Micka merged commit 9ea4660 into microsoft:main Dec 13, 2022
@Cameron-Micka Cameron-Micka linked an issue Dec 13, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Magnify effect for visually impaired people

3 participants