Updates to the Verifier circuit#21
Closed
iontzialla wants to merge 37 commits into
Closed
Conversation
Co-authored-by: porcuquine <porcuquine@users.noreply.github.com>
Co-authored-by: porcuquine <porcuquine@users.noreply.github.com>
(missing an optimization)
…tive. change a in test_mult_mod to expose error
…all hashes with X
marcus-sa
added a commit
to marcus-sa/Nova
that referenced
this pull request
May 15, 2026
…working tree — IdentityStepCircuit + Corrigendum microsoft#22 F2 fixture + 1000-iter empirical close + Falsifier G record Preserves the working-tree state authored at the previous M.GH7.5 third PREPARE (Corrigendum microsoft#21 Path 2 + Corrigendum microsoft#22 F2 single-setup-with- post-mutation fixture-construction algebra). Capture-only commit by the Corrigendum microsoft#23 experiment-protocol crafter dispatch — none of this content is authored by the dispatch crafter; preserved verbatim so the Experiment A/B diagnostic fixtures can stack cleanly on top. Content captured: - `IdentityStepCircuit` + `gh75_lookup_shape` + `gh75_build_honest_fixture` helpers (`compressed_snark.rs` lines ~4191-4472) — Corrigendum microsoft#21 Path 2 fixture algebra implemented via Corrigendum microsoft#22's surgical single-setup-with-post-construction-mutation fix. - `m_gh7_5_b_envelope_verify_ivc_trace_round_trip_byte_equivalence` (the M.GH7.5 acceptance test, line ~4485) — currently FAILS at vendor HEAD inside `gh75_build_honest_fixture`'s `recursive_snark.verify` call with `Err(NovaError::UnSat { sum != U.T })` at n=4. This is Obstruction 2 surfaced under Corrigendum microsoft#23. The test is preserved as-is per the dispatch ("DO NOT commit the failing existing M.GH7.5 acceptance test — that one stays as-is in the working tree until Corrigendum microsoft#24 lands a fix"). - Three negative tests `m_gh7_5_b_corrupted_envelope_per_table_comm_L_rejects`, `m_gh7_5_b_corrupted_envelope_per_table_comm_ts_rejects`, `m_gh7_5_b_corrupted_snapshot_r_U_comm_L_rejects` (preserved; do not pass under the current Obstruction 2 fire because they call `gh75_build_honest_fixture` which itself panics in the verify-side check). - `m_gh7_5_3_build_per_table_synthetic_data_closes_by_construction_1000_iter` (PASSES at vendor HEAD per the 2026-05-13 baseline re-confirmation by the experiment-protocol dispatch — 238s release-mode runtime, 1000 fresh fixtures, n=2 IVC, asserts `envelope.per_table_comm_L[j] == r_U.comm_L[j]` byte-equal). - `m_gh7_5_falsifier_g_obstruction_record_two_pass_ck_non_determinism` (PASSES — Corrigendum microsoft#22 record-the-obstruction discipline). - `src/neutron/mod.rs` visibility bumps to `pub(crate)` on the `RecursiveSNARK` fields `z0`, `ri`, `l_u`, `i`, `running_lws` and `#[serde(skip, default)]` on `shape_registry` — supporting the fixture algebra above. Empirical state recorded by the dispatch at this commit: - `m_gh7_5_3_build_per_table_synthetic_data_closes_by_construction_1000_iter` PASSES (238.50s release-mode, vendor HEAD `39aaec4`). - `m_gh7_5_b_envelope_verify_ivc_trace_round_trip_byte_equivalence` FAILS with `UnSat { sum != U.T, sum: 0x0639af1c..., U.T: 0x0f73deec... }` at `recursive_snark.verify(&pp, GH75_N_STEPS=4, &z0)`. The specific sum/U.T byte values differ across runs (HyperKZG OsRng-sampled tau per Falsifier G obstruction) but the failure class is stable. The Corrigendum microsoft#23 experiment fixtures (A: n=1, B: n=2) follow as separate commits on top of this capture. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.