Arecibo backports#227
Merged
Merged
Conversation
* Optimize generator creation in provider module - Refactored the `from_label` function in pasta.rs removing redundant collect, flatten operations and Vec<usize> creation, * fix: rename VanillaRO -> NativeRO * refactor: Optimize circuit methods and enhance trait compatibility - Replaced the `.map()` function with the `.map_or()` function in `r1cs.rs` for efficiency. - Added `Eq` trait derivation to `NovaAugmentedCircuitParams` in `circuit.rs` to enable comparisons. - Introduced `Eq` trait to `TrivialTestCircuit` struct in `traits/circuit.rs` without altering its input or output. - Optimized performance by refactoring the use of iterator `into_iter()` to the iterator itself in `gadgets/r1cs.rs`.
* ci: Bring clippy standards lurk-rs -> arecibo - Added a new .cargo/config file with a custom alias "xclippy" to execute Clippy lints for code quality assurance, - Fixed code correspondingly when necessary, - Added xclippy to CI * chore: add dbg_macro to ci's clippy - Implemented a new clippy lint for the dbg_macro in the cargo config file
- Enhanced testing for multiple modules, including bellpepper, spartan, and provider, focusing on the addition and multiplication of multi-linear polynomials and the Keccak transcript. - Introduced usage of secp256k1::Scalar (and sometimes bn256_grumpkin::bn256::Scalar) into tests for improved coverage.
hero78119
pushed a commit
to hero78119/SuperNova
that referenced
this pull request
Jan 5, 2024
* NIFS::prove -> NIFS::prove_mut * preallocate witness * simplify resourcebuffer init
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports: