[FancyZones] "Hold a non-primary mouse button" is dependent on "Hold Shift key to activate zones"

[IdmFoundInHim]

Environment

Windows build number: Microsoft Windows [Version 10.0.19628.1]
PowerToys version: 0.18.0
PowerToy module for which you are reporting the bug (if applicable): FancyZones

Steps to reproduce

1. In FancyZones settings, select the following:
   ⬜ Off: Hold Shift Key to activate zones while dragging
   ☑ On: Hold a non-primary mouse button to activate zones while dragging
2. Drag a window (without shift or other mouse buttons)
3. Drag a window while also holding a non-primary (right button, typically) mouse button

Expected behavior

During step 2, the zones should not appear
During step 3, the zones should appear

Only when both settings are off should zones appear without another input.

Actual behavior

During step 2, the zones do appear, and during step 3, the zones disappear.

Additionally, with settings
⬜ Off: Hold Shift Key to activate zones while dragging
⬜ Off: Hold a non-primary mouse button to activate zones while dragging
holding a non-primary mouse button does not cause the zones to disappear, but holding Shift does.

Basically, "Hold a non-primary mouse button" toggles whether FZ pays attention to other mouse buttons. "Hold Shift Key" actually controls what happens when you drag without any other input. Shift always causes something to happen.

[enricogior]

Hi Isaac Myhal (@IdmFoundInHim)

During step 2, the zones should not appear

Make sure your Shift key is not stuck.

[IdmFoundInHim]

Enrico Giordani (@enricogior)
Sorry, I switched the settings when I reformatted my description, so I corrected it. "Hold a non-primary mouse button" is the setting that is on. My Shift key is not stuck, and pressing or releasing Shift aways toggles the state of the zones.

[enricogior]

Isaac Myhal (@IdmFoundInHim)
for 0.18 this is the expected behavior, in 0.19 it will be changed to #2136

[enricogior]

Closing this since it will be changed in 0.19. as per #2136