[Shortcut Guide] Close SG window when win shortcut was pressed#11355
Merged
mykhailopylyp merged 4 commits intoMay 19, 2021
Conversation
mykhailopylyp
added
the
Product-Shortcut Guide
enricogior
approved these changes
May 19, 2021
Contributor
|
Tested, it's a very nice improvement to the SG experience! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
What is this about:
What is include in the PR:
thumb_windowis not initialized. To reproduce it start PT in debug mode, pressWin+Dand try to open SG window.How does someone test / validate:
Try to close SG window with
ESCkey, pressing the shortcut again, pressingWin+keyshortcut, pressing and releasing just win keyQuality Checklist
Contributor License Agreement (CLA)
A CLA must be signed. If not, go over here and sign the CLA.