Disable Shortcut Guide by default on clean installs - #48383
Merged
Conversation
Flips the default for the 'Shortcut Guide' entry in enabledModules from true to false, matching how other newer modules (PowerToys Run, MouseJump, AdvancedPaste, etc.) ship off-by-default. Existing installs are unaffected because their settings.json already persists the user's prior value; only freshly created EnabledModules instances pick up the new default. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
5 tasks
LegendaryBlair
approved these changes
Jun 8, 2026
LegendaryBlair
pushed a commit
that referenced
this pull request
Jun 9, 2026
…48390) ## Summary of the Pull Request Visual polish for the Shortcut Guide UI, follow-up to #48383 and #48384. - Fixes the Settings footer icon being clipped in the rail at startup. Root cause: the icon `RowDefinition` in `CustomNavigationViewStyle.xaml` was `*`, so the rail's `MinHeight` constraint compressed the 20px icon down. Changing it to `Auto` lets the row size to its content. This also removes the need for the `FakeSettingsButton` workaround. - Replaces the laptop `FontIcon` used for the `Windows` nav entry with a 4-square Windows logo rendered as a `PathIcon`. - Replaces the bitmap PowerToys app icon with a theme-aware vector `PathIcon` (rounded square frame + menu bar + three dots) so it matches the rest of the icons. - Path data for both icons lives as `x:String` resources in `App.xaml`. - Tunes the rail item `Row 0` height so the icon vertically aligns with the selection pill center. <img width="681" height="1405" alt="image" src="https://github.com/user-attachments/assets/10787087-e32f-4018-b004-3f824648b962" /> ## PR Checklist - [x] **Closes:** part of the Shortcut Guide 0.100 polish set - [x] **Communication:** internal only - [x] **Tests:** manual verification - [x] **Localization:** no new strings - [x] **Dev docs:** N/A ## Validation Steps Performed - Built locally and verified the Settings footer icon is no longer clipped on first show. - Verified the Windows nav entry now uses the Windows logo PathIcon and renders correctly in light and dark. - Verified the PowerToys entry now renders as a vector and follows the theme foreground. - Verified the selection pill aligns vertically with the icon center. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
LegendaryBlair
added
the
Product-Shortcut Guide
babamottos-bit
approved these changes
Jun 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Flips the default for the
Shortcut Guideentry inenabledModulesfromtruetofalse. New PowerToys installs (no priorsettings.json) will start with Shortcut Guide disabled, matching how other newer modules (PowerToys Run, MouseJump, AdvancedPaste, MouseWithoutBorders, CropAndLock, QuickAccent, TextExtractor, MousePointerCrosshairs, KeyboardManager) already ship off-by-default inEnabledModules.cs.Why
Shortcut Guide has been on-by-default since the early days, but it is an opt-in style utility (overlay launched on hotkey). It should not be active for users who never asked for it on a fresh install.
Changes
src/settings-ui/Settings.UI.Library/EnabledModules.cs-- flipshortcutGuidebacking field from= trueto bare declaration with the file's// defaulting to offcomment convention.src/settings-ui/Settings.UI.UnitTests/ViewModelTests/General.cs-- update the correspondingAllModulesAreEnabledByDefaultassertion.Compatibility
Existing installs are unaffected: their
settings.jsonalready persists the user's prior value (true), so anyone who has it on today keeps it on. Only freshly createdEnabledModulesinstances pick up the new default.