MAINT: Memory Model cleanup - #1937
Merged
Merged
Conversation
…n helpers Centralize naive->UTC datetime normalization in a UTCDateTime TypeDecorator (fixes latent naive completion_time bug) and factor repeated identifier model_dump/model_validate calls into explicit helper functions. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
romanlutz
reviewed
Jun 4, 2026
romanlutz
approved these changes
Jun 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This converts simplifies our memory model class. It is phase 11 of the pyrit.models refactor
https://gist.github.com/rlundeen2/3e8daa8e12a11b4b6e52587b3c9b1dca
This doesn't clean up as much as I thought we could; we still have to repeat things. That's because sqlalchemy reserves some important extensions (like ID) and needs to coerce types in an incompatible way (e.g. some things are serialized and truncated).
So in this PR we don't gain much from the thin models, but it's still a win.