Skip to content

Fix SQL Server key-type migration issue and preserve Alembic revision - #2026

Merged
hannahwestra25 merged 3 commits into
microsoft:mainfrom
behnam-o:fix-for-az-sql-limitation
Jun 17, 2026
Merged

Fix SQL Server key-type migration issue and preserve Alembic revision#2026
hannahwestra25 merged 3 commits into
microsoft:mainfrom
behnam-o:fix-for-az-sql-limitation

Conversation

@behnam-o

@behnam-o behnam-o commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

[This will require a force-push because it updates existing migration files]

This PR fixes a migration regression where Conversations.conversation_id could be treated as an unbounded string key type on SQL Server, which is invalid for indexed key columns.

Problem

Solution

  • Updated b2f4c6a8d1e3 to define Conversations.conversation_id as a bounded string (String(length=36)).
  • Removed d4e5f6a7b8c9 revision which should no longer be needed.
  • Added migration test coverage to catch unbounded string primary keys in revision files going forward.

@hannahwestra25
hannahwestra25 enabled auto-merge June 17, 2026 14:50
@hannahwestra25
hannahwestra25 disabled auto-merge June 17, 2026 14:53
@hannahwestra25
hannahwestra25 enabled auto-merge June 17, 2026 14:53
@hannahwestra25
hannahwestra25 disabled auto-merge June 17, 2026 14:54
@hannahwestra25
hannahwestra25 enabled auto-merge June 17, 2026 14:54
@hannahwestra25
hannahwestra25 added this pull request to the merge queue Jun 17, 2026
Merged via the queue into microsoft:main with commit be4b551 Jun 17, 2026
50 of 53 checks passed
@behnam-o
behnam-o deleted the fix-for-az-sql-limitation branch July 1, 2026 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants