Fix SQL Server key-type migration issue and preserve Alembic revision - #2026
Merged
hannahwestra25 merged 3 commits intoJun 17, 2026
Merged
Conversation
hannahwestra25
approved these changes
Jun 17, 2026
hannahwestra25
enabled auto-merge
June 17, 2026 14:50
hannahwestra25
disabled auto-merge
June 17, 2026 14:53
hannahwestra25
enabled auto-merge
June 17, 2026 14:53
hannahwestra25
disabled auto-merge
June 17, 2026 14:54
hannahwestra25
enabled auto-merge
June 17, 2026 14:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[This will require a force-push because it updates existing migration files]
This PR fixes a migration regression where
Conversations.conversation_idcould be treated as an unbounded string key type on SQL Server, which is invalid for indexed key columns.Problem
VARCHAR/NVARCHAR(MAX)).Solution
b2f4c6a8d1e3to defineConversations.conversation_idas a bounded string (String(length=36)).d4e5f6a7b8c9revision which should no longer be needed.