FIX ModuleNotFoundError in Azure SQL memory integration test - #2130
Merged
Conversation
romanlutz
approved these changes
Jul 7, 2026
jsong468
approved these changes
Jul 7, 2026
jsong468
left a comment
Contributor
There was a problem hiding this comment.
Thanks for fixing! I wonder in the future if we want something like a shared_mocks.py module for both unit and integration test use in the parent tests/ directory?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test_azure_sql_memory_integration.pyimportedmake_scenario_resultfromunit.mocks, which is only importable during unit-test collection (where pytest's--import-mode=importlibputstests/onsys.pathvia the unitconftest.py/__init__.pychain). Under the integration suite that path isn't established, so every test in the file failed at collection with:Fix
Made the file self-contained instead of reaching across test tiers:
from unit.mocks import make_scenario_result.ScenarioIdentifier/ScenarioResultto the existingpyrit.modelsimport.make_scenario_resulthelper that pointsclass_moduleat the integration module.This matches the file's existing pattern (
get_test_scorer_identifier,get_test_atomic_attack_identifier) and keeps the integration suite independent of the unit tree.Testing
All 7 tests in the file now collect cleanly.