FIX: Preserve all AcrosticConverter input characters - #2384
Merged
Roman Lutz (romanlutz) merged 4 commits intoAug 13, 2026
Conversation
Change-Id: I773fc7405da89888ecd2a5248cf64d1191dec83a
Roman Lutz (romanlutz)
approved these changes
Aug 13, 2026
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 1cbb1f3d-6e39-4266-910f-2ef136a3e289
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 1cbb1f3d-6e39-4266-910f-2ef136a3e289
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #2383.
AcrosticConverternow preserves digits, punctuation, Unicode whitespace, and non-letter characters instead of filtering them out. Alphabetic characters still follow the converter’s uppercase contract, including characters whose uppercase form expands to multiple code points.The whitespace encoding uses explicit sentinel lines and escapes sentinel characters so
decode()can reconstruct the complete converted prompt. Empty prompts now decode to an empty string.Tests and Documentation
15,029 passed, 120 skippedacross the unit suite, excluding one unrelatedComicJailbreakDatasettest that times out fetching a remote image on the unchanged base commit as well.typass for the changed files.