Skip to content

FIX: Preserve all AcrosticConverter input characters - #2384

Merged
Roman Lutz (romanlutz) merged 4 commits into
microsoft:mainfrom
Boulea7:fix/2383-preserve-characters
Aug 13, 2026
Merged

FIX: Preserve all AcrosticConverter input characters#2384
Roman Lutz (romanlutz) merged 4 commits into
microsoft:mainfrom
Boulea7:fix/2383-preserve-characters

Conversation

@Boulea7

Copy link
Copy Markdown
Contributor

Description

Fixes #2383.

AcrosticConverter now preserves digits, punctuation, Unicode whitespace, and non-letter characters instead of filtering them out. Alphabetic characters still follow the converter’s uppercase contract, including characters whose uppercase form expands to multiple code points.

The whitespace encoding uses explicit sentinel lines and escapes sentinel characters so decode() can reconstruct the complete converted prompt. Empty prompts now decode to an empty string.

Tests and Documentation

  • Updated the focused converter tests with mixed text, sentinel collisions, Unicode uppercase expansions, non-letter uppercase mappings, and empty input.
  • 15,029 passed, 120 skipped across the unit suite, excluding one unrelated ComicJailbreakDataset test that times out fetching a remote image on the unchanged base commit as well.
  • Ruff format/check and ty pass for the changed files.
  • JupyText not run because converter notebooks were not changed.

Copilot AI added 2 commits August 12, 2026 22:28
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 1cbb1f3d-6e39-4266-910f-2ef136a3e289
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 1cbb1f3d-6e39-4266-910f-2ef136a3e289
@romanlutz
Roman Lutz (romanlutz) added this pull request to the merge queue Aug 13, 2026
Merged via the queue into microsoft:main with commit 850d92c Aug 13, 2026
54 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BUG: AcrosticConverter silently drops digits and punctuation

3 participants