Skip to content

Update Demo Notebook Prerequisites#30

Merged
rdheekonda merged 4 commits intomainfrom
users/rdheekonda/fix-prerequisites-notebooks-and-wiki
Jan 31, 2024
Merged

Update Demo Notebook Prerequisites#30
rdheekonda merged 4 commits intomainfrom
users/rdheekonda/fix-prerequisites-notebooks-and-wiki

Conversation

@rdheekonda
Copy link
Copy Markdown
Contributor

@rdheekonda rdheekonda commented Jan 30, 2024 •
edited
Loading

Description

  1. Updated prerequisites documentation for running demo notebooks.
  2. Removed Azure CLI from the wiki prerequisites.

image

Tests

  • no new tests required
  • new tests added
  • existing tests adjusted

Documentation

  • no documentation changes needed
  • documentation added or edited
  • example notebook added or updated

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jan 30, 2024 •
edited
Loading

Test Results

72 tests  ±0   72 ✅ ±0   6s ⏱️ -1s
 1 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit 4e50903. ± Comparison against base commit b67f726.

♻️ This comment has been updated with latest results.

nina-msft
nina-msft reviewed Jan 31, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@nina-msft nina-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another approach could be to put all of this information into this setup page: https://github.com/Azure/PyRIT/blob/users/rdheekonda/fix-prerequisites-notebooks-and-wiki/examples/setup/azure_openai_setup.ipynb

There are some notebooks in examples/code that will reference this setup, and it seems like this can be leveraged for all 3 of these notebooks.

@rdheekonda
Copy link
Copy Markdown
Contributor Author

rdheekonda commented Jan 31, 2024

Another approach could be to put all of this information into this setup page: https://github.com/Azure/PyRIT/blob/users/rdheekonda/fix-prerequisites-notebooks-and-wiki/examples/setup/azure_openai_setup.ipynb

There are some notebooks in examples/code that will reference this setup, and it seems like this can be leveraged for all 3 of these notebooks.

Good suggestion, updated. Thanks

romanlutz
romanlutz approved these changes Jan 31, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@romanlutz romanlutz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

rdheekonda
rdheekonda commented Jan 31, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor Author

@rdheekonda rdheekonda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated text

@rdheekonda @romanlutz
Apply suggestions from code review
4e50903 
Co-authored-by: Roman Lutz <romanlutz13@gmail.com>
@rdheekonda rdheekonda merged commit 4aace51 into main Jan 31, 2024
@rdheekonda rdheekonda deleted the users/rdheekonda/fix-prerequisites-notebooks-and-wiki branch January 31, 2024 16:34
romanlutz added a commit to romanlutz/PyRIT that referenced this pull request Mar 13, 2026
@romanlutz
Fix 11 Dependabot security alerts
1cef388 
- Bump pypdf >=6.7.5 -> >=6.8.0 (direct dep, fixes microsoft#56)
- Bump gradio >=5.32.0 -> >=6.7.0 (optional dep, fixes microsoft#49-52)
- Add orjson >=3.11.6 constraint (transitive, fixes microsoft#59)
- Add tornado >=6.5.5 constraint (transitive, fixes microsoft#57-58)
- Fix minimatch ReDoS via npm audit fix (fixes microsoft#46-47)
- Add @tootallnate/once >=3.0.1 npm override (fixes microsoft#55)
- diskcache microsoft#30 has no patched version available

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@romanlutz romanlutz mentioned this pull request Mar 13, 2026
Merged
romanlutz added a commit to romanlutz/PyRIT that referenced this pull request Mar 13, 2026
@romanlutz
Fix 11 Dependabot security alerts
2b86af3 
- Bump pypdf >=6.7.5 -> >=6.8.0 (direct dep, fixes microsoft#56)
- Bump gradio >=5.32.0 -> >=6.7.0 (optional dep, fixes microsoft#49-52)
- Add orjson >=3.11.6 constraint (transitive, fixes microsoft#59)
- Add tornado >=6.5.5 constraint (transitive, fixes microsoft#57-58)
- Fix minimatch ReDoS via npm audit fix (fixes microsoft#46-47)
- Add @tootallnate/once >=3.0.1 npm override (fixes microsoft#55)
- diskcache microsoft#30 has no patched version available

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@romanlutz romanlutz romanlutz approved these changes

@nina-msft nina-msft nina-msft approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rdheekonda @romanlutz @nina-msft