Skip to content

Add Details to Contributor Guide About Forking/PRs#59

Merged
nina-msft merged 9 commits intomicrosoft:mainfrom
nina-msft:users/nina-msft/contributor-guide-additions
Feb 22, 2024
Merged

Add Details to Contributor Guide About Forking/PRs#59
nina-msft merged 9 commits intomicrosoft:mainfrom
nina-msft:users/nina-msft/contributor-guide-additions

Conversation

@nina-msft
Copy link
Copy Markdown
Contributor

@nina-msft nina-msft commented Feb 22, 2024

Description

Add info about how to contribute via Git to the Contributor Guide, from creating a fork to adding the remote locally to creating a PR 🤠 ✨

See markdown preview here: https://github.com/nina-msft/PyRIT/blob/users/nina-msft/contributor-guide-additions/doc/contributing.md

Tests

  • no new tests required
  • new tests added
  • existing tests adjusted

Documentation

  • no documentation changes needed
  • documentation added or edited
  • example notebook added or updated

@nina-msft nina-msft marked this pull request as ready for review February 22, 2024 01:36
Copy link
Copy Markdown
Contributor

@romanlutz romanlutz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just very nitpicky comments. This is great, thanks!

@nina-msft nina-msft merged commit 6748b48 into microsoft:main Feb 22, 2024
@nina-msft nina-msft deleted the users/nina-msft/contributor-guide-additions branch February 22, 2024 02:05
romanlutz added a commit to romanlutz/PyRIT that referenced this pull request Mar 13, 2026
- Bump pypdf >=6.7.5 -> >=6.8.0 (direct dep, fixes microsoft#56)
- Bump gradio >=5.32.0 -> >=6.7.0 (optional dep, fixes microsoft#49-52)
- Add orjson >=3.11.6 constraint (transitive, fixes microsoft#59)
- Add tornado >=6.5.5 constraint (transitive, fixes microsoft#57-58)
- Fix minimatch ReDoS via npm audit fix (fixes microsoft#46-47)
- Add @tootallnate/once >=3.0.1 npm override (fixes microsoft#55)
- diskcache microsoft#30 has no patched version available

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
romanlutz added a commit to romanlutz/PyRIT that referenced this pull request Mar 13, 2026
- Bump pypdf >=6.7.5 -> >=6.8.0 (direct dep, fixes microsoft#56)
- Bump gradio >=5.32.0 -> >=6.7.0 (optional dep, fixes microsoft#49-52)
- Add orjson >=3.11.6 constraint (transitive, fixes microsoft#59)
- Add tornado >=6.5.5 constraint (transitive, fixes microsoft#57-58)
- Fix minimatch ReDoS via npm audit fix (fixes microsoft#46-47)
- Add @tootallnate/once >=3.0.1 npm override (fixes microsoft#55)
- diskcache microsoft#30 has no patched version available

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants