Skip to content

[META]: Correct PR template - #28

Merged
Spencer Schoenberg (spencrr) merged 1 commit into
mainfrom
spencrr/correct-pr-template
Apr 22, 2026
Merged

[META]: Correct PR template#28
Spencer Schoenberg (spencrr) merged 1 commit into
mainfrom
spencrr/correct-pr-template

Conversation

@spencrr

Copy link
Copy Markdown
Contributor

Description

Move the PR template - UI seems to not pickup options from the .github/PULL_REQUEST_TEMPLATE folder - since we have just the one template, avoiding complexity and moving to .github.

Breaking changes

None

Checklist

  • pre-commit run --all-files passes
  • Tests added or updated for changes
  • Documentation updated

@spencrr
Spencer Schoenberg (spencrr) requested a review from a team April 22, 2026 03:33

@nina-msft Nina Chikanov (nina-msft) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looked up why this might be the case (docs) -- seems like if we want to use a subdirectory it needs to be within root or docs/, or we need to use a query parameter?

To create multiple pull request templates and use the template query parameter to specify a template to fill the pull request body, type .github/PULL_REQUEST_TEMPLATE/, then the name of your pull request template. For example, .github/PULL_REQUEST_TEMPLATE/pull_request_template.md. You can also store multiple pull request templates in a PULL_REQUEST_TEMPLATE subdirectory within the root or docs/ directories. For more information, see Using query parameters to create a pull request.

Either way, this change works for a single PR template 🫡

@spencrr

Spencer Schoenberg (spencrr) commented Apr 22, 2026

Copy link
Copy Markdown
Contributor Author

Looked up why this might be the case (docs) -- seems like if we want to use a subdirectory it needs to be within root or docs/, or we need to use a query parameter?

To create multiple pull request templates and use the template query parameter to specify a template to fill the pull request body, type .github/PULL_REQUEST_TEMPLATE/, then the name of your pull request template. For example, .github/PULL_REQUEST_TEMPLATE/pull_request_template.md. You can also store multiple pull request templates in a PULL_REQUEST_TEMPLATE subdirectory within the root or docs/ directories. For more information, see Using query parameters to create a pull request.

Either way, this change works for a single PR template 🫡

I was shooting for the UI to show something like this which is supported with the .github/PULL_REQUEST_TEMPLATE
but maybe you need the default to be just in .github 🤷‍♂️ we only have one for now 🤣
image

@spencrr
Spencer Schoenberg (spencrr) merged commit 23f1f18 into main Apr 22, 2026
9 of 13 checks passed
@spencrr
Spencer Schoenberg (spencrr) deleted the spencrr/correct-pr-template branch April 22, 2026 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants