Add digest context copy function - #158
Merged
Merged
Conversation
Copilot started reviewing on behalf of
Maxwell Moyer-McKee (mamckee)
February 9, 2026 21:33
View session
Contributor
There was a problem hiding this comment.
Pull request overview
Adds support for OpenSSL’s newer digest “copy context into an existing ctx” provider callback (OSSL_FUNC_DIGEST_COPYCTX) to complement the existing “duplicate context” (DUPCTX) implementation.
Changes:
- Introduces
p_scossl_digest_copy_ctxfor copying digest state into an existingSCOSSL_DIGEST_CTXwhenOSSL_FUNC_DIGEST_COPYCTXis available. - Updates digest dispatch table macro generation to conditionally include
OSSL_FUNC_DIGEST_COPYCTXfor newer OpenSSL versions. - Refactors the shared digest macro to separate “common helper function implementations” from “dispatch table construction”.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| SymCryptProvider/src/digests/p_scossl_digest_common.h | Declares copyctx and conditionally adds it to the digest dispatch macro. |
| SymCryptProvider/src/digests/p_scossl_digest_common.c | Implements p_scossl_digest_copy_ctx using SymCrypt’s stateCopyFunc. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Maxwell Moyer-McKee (mamckee)
requested review from
MS-megliu and
Samuel Lee (samuel-lee-msft)
February 18, 2026 23:16
Maxwell Moyer-McKee (mamckee)
marked this pull request as ready for review
February 18, 2026 23:19
Maxwell Moyer-McKee (mamckee)
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the provider context copy function for newer versions of OpenSSL. This function copies the state into an existing context object instead of creating a new context object like context duplication.