Skip to content

Add setup components for use with insertion into VS#45

Merged
spebl merged 12 commits intodev15from
dev/spebl/setup
Sep 21, 2017
Merged

Add setup components for use with insertion into VS#45
spebl merged 12 commits intodev15from
dev/spebl/setup

Conversation

@spebl
Copy link
Copy Markdown

@spebl spebl commented Sep 21, 2017

We have microbuild set up to build the swixproj and vsmanproj to generate a vsman for us to merge into the main setup for Visual Studio. Currently the projects under swix/res aren't being used but are there to support localization which is coming soon. Verified the installation with a VAL build on the VS side pulling in a VAL build from this side and setup was all working.

@spebl spebl requested review from a team and LukaszMendakiewicz September 21, 2017 01:47
@msftclas
Copy link
Copy Markdown

@spebl,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

package name=Microsoft.VisualStudio.VC.Ide.TestAdapterForGoogleTest
version=$(Version)
vs.package.type=vsix
vs.package.installSize=22265856
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should note in the Release steps to keep this up-to-date.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will do!

Comment thread swix/packages.config
<?xml version="1.0" encoding="utf-8"?>
<packages>
<package id="MicroBuild.Core" version="0.2.0" targetFramework="net46" developmentDependency="true" />
<package id="Nerdbank.GitVersioning" version="1.4.30" targetFramework="net46" developmentDependency="true" />
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ensure we have this registered for internal usage.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe we should, many other packages are using it. I'll double check to be sure.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved!

package name=Microsoft.VisualStudio.VC.Ide.TestAdapterForGoogleTest
version=$(Version)
vs.package.type=vsix
vs.package.installSize=22265856
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto; but also should this be duplicated size? (We can fix it later)

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not currently used, will fix later.

vs.package.vsixId=GoogleTestAdapterVSIX.8486b54e-5768-482b-b224-7d069ca509d8

vs.payloads
vs.payload source=$(VsixOutDir)\Packaging.TAfGT.vsix
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is duplicating this in other swr intentional?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't built right now as well. I wanted to keep the structure, maybe should have dumped some empty files instead but this will make it easier going forward.

@LukaszMendakiewicz LukaszMendakiewicz added this to the next milestone Sep 21, 2017
@spebl spebl merged commit 73d4974 into dev15 Sep 21, 2017
@bobbrow bobbrow deleted the dev/spebl/setup branch November 25, 2025 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants