Enhance agent features and improve clientIO functionality

.github/workflows/build-ts.yml

@@ -124,7 +124,7 @@ jobs:
         shell: bash
         run: |
           git fetch --no-tags origin "${{ github.base_ref }}"
-          npm run code-circular -- --ratchet --base "origin/${{ github.base_ref }}"
+          npm run code-circular -- --ratchet --base "origin/${{ github.base_ref }}" --exceptions-file tools/scripts/code/circular-baseline-exception.json
       # Test-debt gate (PRs only): zero tolerance for focused tests
       # (.only/fit/fdescribe) and no newly skipped tests (.skip/xit/xdescribe)
       # in changed files.  A small, fixable problem -> a hard gate, not a ratchet.

dotnet/autoShell.Tests/ActionDispatcherIntegrationTests.cs

@@ -26,6 +26,7 @@ public class ActionDispatcherIntegrationTests
     private readonly Mock<IWindowService> _windowMock = new();
     private readonly Mock<INetworkService> _networkMock = new();
     private readonly Mock<IVirtualDesktopService> _virtualDesktopMock = new();
+    private readonly Mock<IServiceControlService> _serviceControlMock = new();
     private readonly Mock<ILogger> _loggerMock = new();
     private readonly ActionDispatcher _dispatcher;
 
@@ -43,7 +44,8 @@ public ActionDispatcherIntegrationTests()
             _displayMock.Object,
             _windowMock.Object,
             _networkMock.Object,
-            _virtualDesktopMock.Object);
+            _virtualDesktopMock.Object,
+            _serviceControlMock.Object);
     }
 
     /// <summary>

dotnet/autoShell.Tests/HandlerRegistrationTests.cs

@@ -29,6 +29,7 @@ public HandlerRegistrationTests()
         var windowMock = new Mock<IWindowService>();
         var networkMock = new Mock<INetworkService>();
         var virtualDesktopMock = new Mock<IVirtualDesktopService>();
+        var serviceControlMock = new Mock<IServiceControlService>();
         var loggerMock = new Mock<ILogger>();
 
         _handlers =
@@ -50,6 +51,7 @@ public HandlerRegistrationTests()
             new PrivacySettingsHandler(registryMock.Object),
             new SystemSettingsHandler(registryMock.Object, processMock.Object),
             new SystemActionHandler(processMock.Object, debuggerMock.Object),
+            new ServiceActionHandler(serviceControlMock.Object),
         ];
     }
 

dotnet/autoShell.Tests/ServiceActionHandlerTests.cs

@@ -0,0 +1,180 @@
+// Copyright (c) Microsoft Corporation.
+// Licensed under the MIT License.
+
+using System.Text.Json;
+using autoShell.Handlers;
+using autoShell.Services;
+using Moq;
+
+namespace autoShell.Tests;
+
+public class ServiceActionHandlerTests
+{
+    private readonly Mock<IServiceControlService> _serviceMock = new();
+    private readonly ServiceActionHandler _handler;
+
+    public ServiceActionHandlerTests()
+    {
+        _handler = new ServiceActionHandler(_serviceMock.Object);
+    }
+
+    /// <summary>
+    /// Verifies that RestartService with matchBy "name" locates the service by name.
+    /// </summary>
+    [Fact]
+    public void RestartService_MatchByName_CallsServiceByName()
+    {
+        _serviceMock
+            .Setup(s => s.RestartService("Spooler", false, false))
+            .Returns(ServiceControlResult.Ok("Print Spooler"));
+
+        var json = JsonDocument.Parse("""{"service":"Spooler","matchBy":"name"}""").RootElement;
+        var result = _handler.Handle("RestartService", json);
+
+        Assert.True(result.Success);
+        _serviceMock.Verify(s => s.RestartService("Spooler", false, false), Times.Once);
+    }
+
+    /// <summary>
+    /// Verifies that RestartService with matchBy "description" locates the service by description.
+    /// </summary>
+    [Fact]
+    public void RestartService_MatchByDescription_CallsServiceByDescription()
+    {
+        _serviceMock
+            .Setup(s => s.RestartService("windows update", true, false))
+            .Returns(ServiceControlResult.Ok("Windows Update"));
+
+        var json = JsonDocument.Parse("""{"service":"windows update","matchBy":"description"}""").RootElement;
+        var result = _handler.Handle("RestartService", json);
+
+        Assert.True(result.Success);
+        _serviceMock.Verify(s => s.RestartService("windows update", true, false), Times.Once);
+    }
+
+    /// <summary>
+    /// Verifies that RestartService without matchBy defaults to matching by name.
+    /// </summary>
+    [Fact]
+    public void RestartService_NoMatchBy_DefaultsToName()
+    {
+        _serviceMock
+            .Setup(s => s.RestartService("Audiosrv", false, false))
+            .Returns(ServiceControlResult.Ok("Windows Audio"));
+
+        var json = JsonDocument.Parse("""{"service":"Audiosrv"}""").RootElement;
+        _handler.Handle("RestartService", json);
+
+        _serviceMock.Verify(s => s.RestartService("Audiosrv", false, false), Times.Once);
+    }
+
+    /// <summary>
+    /// Verifies that the resolved service display name is included in the success message.
+    /// </summary>
+    [Fact]
+    public void RestartService_Success_ReturnsDisplayNameInMessage()
+    {
+        _serviceMock
+            .Setup(s => s.RestartService(It.IsAny<string>(), It.IsAny<bool>(), It.IsAny<bool>()))
+            .Returns(ServiceControlResult.Ok("Print Spooler"));
+
+        var json = JsonDocument.Parse("""{"service":"Spooler"}""").RootElement;
+        var result = _handler.Handle("RestartService", json);
+
+        Assert.True(result.Success);
+        Assert.Contains("Print Spooler", result.Message);
+    }
+
+    /// <summary>
+    /// Verifies that a failure from the service is surfaced as a failed result with its error message.
+    /// </summary>
+    [Fact]
+    public void RestartService_ServiceFails_ReturnsFailureWithError()
+    {
+        _serviceMock
+            .Setup(s => s.RestartService(It.IsAny<string>(), It.IsAny<bool>(), It.IsAny<bool>()))
+            .Returns(ServiceControlResult.Fail("No Windows service found with the name or display name 'bogus'."));
+
+        var json = JsonDocument.Parse("""{"service":"bogus"}""").RootElement;
+        var result = _handler.Handle("RestartService", json);
+
+        Assert.False(result.Success);
+        Assert.Contains("bogus", result.Message);
+    }
+
+    /// <summary>
+    /// Verifies that an empty service identifier returns a failure without calling the service.
+    /// </summary>
+    [Fact]
+    public void RestartService_EmptyService_ReturnsFailure()
+    {
+        var json = JsonDocument.Parse("""{"service":""}""").RootElement;
+        var result = _handler.Handle("RestartService", json);
+
+        Assert.False(result.Success);
+        _serviceMock.Verify(s => s.RestartService(It.IsAny<string>(), It.IsAny<bool>(), It.IsAny<bool>()), Times.Never);
+    }
+
+    /// <summary>
+    /// Verifies that a fuzzy match returns a success result carrying a confirmation payload
+    /// (rather than restarting anything) so the agent can confirm the target with the user.
+    /// </summary>
+    [Fact]
+    public void RestartService_FuzzyMatch_ReturnsConfirmationData()
+    {
+        _serviceMock
+            .Setup(s => s.RestartService("spool", false, false))
+            .Returns(ServiceControlResult.Confirm("Spooler", "Print Spooler"));
+
+        var json = JsonDocument.Parse("""{"service":"spool"}""").RootElement;
+        var result = _handler.Handle("RestartService", json);
+
+        Assert.True(result.Success);
+        Assert.NotNull(result.Data);
+        JsonElement data = result.Data.Value;
+        Assert.True(data.GetProperty("needsConfirmation").GetBoolean());
+        Assert.Equal("Spooler", data.GetProperty("resolvedServiceName").GetString());
+        Assert.Equal("Print Spooler", data.GetProperty("resolvedDisplayName").GetString());
+        Assert.Equal("restart", data.GetProperty("operation").GetString());
+    }
+
+    /// <summary>
+    /// Verifies that when the service reports elevation is required, the handler returns a success
+    /// result carrying an elevation-confirmation payload (rather than restarting anything).
+    /// </summary>
+    [Fact]
+    public void RestartService_NeedsElevation_ReturnsElevationData()
+    {
+        _serviceMock
+            .Setup(s => s.RestartService("Spooler", false, false))
+            .Returns(ServiceControlResult.Elevate("Spooler", "Print Spooler"));
+
+        var json = JsonDocument.Parse("""{"service":"Spooler"}""").RootElement;
+        var result = _handler.Handle("RestartService", json);
+
+        Assert.True(result.Success);
+        Assert.NotNull(result.Data);
+        JsonElement data = result.Data.Value;
+        Assert.True(data.GetProperty("needsElevation").GetBoolean());
+        Assert.Equal("Spooler", data.GetProperty("resolvedServiceName").GetString());
+        Assert.Equal("Print Spooler", data.GetProperty("resolvedDisplayName").GetString());
+        Assert.Equal("restart", data.GetProperty("operation").GetString());
+    }
+
+    /// <summary>
+    /// Verifies that once the user has consented, the elevate flag is forwarded to the service.
+    /// </summary>
+    [Fact]
+    public void RestartService_ElevateTrue_PassesElevateToService()
+    {
+        _serviceMock
+            .Setup(s => s.RestartService("Spooler", false, true))
+            .Returns(ServiceControlResult.Ok("Print Spooler"));
+
+        var json = JsonDocument.Parse("""{"service":"Spooler","matchBy":"name","elevate":true}""").RootElement;
+        var result = _handler.Handle("RestartService", json);
+
+        Assert.True(result.Success);
+        _serviceMock.Verify(s => s.RestartService("Spooler", false, true), Times.Once);
+    }
+}