dispatcher: remove TypeScript schema stitch mode - #2759
Merged
Conversation
The dispatcher translator had two code paths: a generated schema path (using action-schema to build the schema at runtime) and a legacy stitch path (reading and concatenating raw .ts source files via TypeChat's TypeScript validator). The stitch path was the fallback when schema.generation.enabled was false. Remove the stitch path entirely: - Drop getTranslatorSchemaDef, getTranslatorSchemaDefs, getChangeAssistantSchemaDef from agentTranslators.ts - createTypeAgentValidator and getFullSchemaText now unconditionally use the generated path - Remove schema.generation.enabled from the session config type and defaults - Remove the @config schema generation on/off command handler - Remove --generated/--no-generated from the CLI schema command
curtisman
enabled auto-merge
July 29, 2026 22:41
robgruen
approved these changes
Jul 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the non-generated TypeScript schema composition path from dispatcher translation and makes generated action schema the only supported mode.
Why
What changed
schema.generation.enabledfrom dispatcher config type/defaults.createTypeAgentValidatornow always builds fromcomposeActionSchema+createActionSchemaJsonValidator.loadAgentJsonTranslator/getFullSchemaTextsignatures now always take generation options (no nullable mode switch).getTranslatorForSchemanow always constructs generation options (no null branch).