Skip to content

Conversation

@typescript-bot
Copy link
Contributor

Automated changes by create-pull-request GitHub action

@github-actions
Copy link
Contributor

github-actions bot commented Nov 1, 2025

Thanks for the PR!

This section of the codebase is owned by @saschanaz - if they write a comment saying "LGTM" then it will be merged.

@saschanaz
Copy link
Contributor

We'll need to see whether this breaks @Bashamega's MDN patch. LGTM for now

@github-actions
Copy link
Contributor

github-actions bot commented Nov 1, 2025

There was an issue merging, maybe try again saschanaz. Details

@Bashamega
Copy link
Contributor

This would require a rebase; it is better to wait until the other PR is merged.
Thanks for notifying me @saschanaz

@jakebailey
Copy link
Member

Hm, is this missing the mdn file update?

@jakebailey
Copy link
Member

Well, CI worked, so it must be fine

@Bashamega
Copy link
Contributor

It is not missing it @jakebailey
I just updated it before you merged it, so there is no new updates.

The script is working correctly

@jakebailey
Copy link
Member

Ah, ok, I reran hoping to test it but that's fine.

@jakebailey
Copy link
Member

But then, why is this PR all doc updates without mdn.json?

@saschanaz
Copy link
Contributor

Maybe comments were latest enough but BCD was not?

@saschanaz
Copy link
Contributor

In any case, LGTM

@github-actions
Copy link
Contributor

github-actions bot commented Nov 1, 2025

There was an issue merging, maybe try again saschanaz. Details

@saschanaz
Copy link
Contributor

Still LGTM

@github-actions
Copy link
Contributor

github-actions bot commented Nov 2, 2025

There was an issue merging, maybe try again saschanaz. Details

@jakebailey jakebailey merged commit ad36cbe into microsoft:main Nov 2, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants