Merged
Conversation
popup's positioning is not ideal mdn links need to be added too
Contributor
|
This is close! I want to auto-generate the JSON object and then we're good |
Contributor
|
There we go - thanks @alirezaghey ! |
Contributor
Author
Contributor
|
I've left some of my ideas on the MDN and docs pages, the tricky thing is making a markdown summary but I've included a pretty reasonable idea for how that could happen. Re: popup positioning, that's doable - it's just JavaScript and deciding which side is closest to the middle of the page and using that edge to position the popover instead of right now where it's the bottom always. I'd start with maybe doing either above or below first, and then look at left or right |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds popups for tsconfig links
Popup positioning is not ideal
Related to #1656