Skip to content

Add wikipedia like popups#1911

Merged
orta merged 7 commits intomicrosoft:v2from
alirezaghey:feature-popup
Jul 26, 2021
Merged

Add wikipedia like popups#1911
orta merged 7 commits intomicrosoft:v2from
alirezaghey:feature-popup

Conversation

@alirezaghey
Copy link
Copy Markdown
Contributor

Adds popups for tsconfig links
Popup positioning is not ideal
Related to #1656

popup's positioning is not ideal
mdn links need to be added too
@ghost
Copy link
Copy Markdown

ghost commented Jun 30, 2021

CLA assistant check
All CLA requirements met.

@orta
Copy link
Copy Markdown
Contributor

orta commented Jul 21, 2021

This is close! I want to auto-generate the JSON object and then we're good

@orta orta enabled auto-merge July 26, 2021 07:24
@orta orta merged commit 71e8f61 into microsoft:v2 Jul 26, 2021
@orta
Copy link
Copy Markdown
Contributor

orta commented Jul 26, 2021

There we go - thanks @alirezaghey !

@alirezaghey
Copy link
Copy Markdown
Contributor Author

Thanks @orta, this looks amazing! I'll look into how we can add MDN and internal documentation pages according to #1656 and also how we can make the popups aware of their position on the page so that they move a little bit to the opposite side like how they do on wikipedia.

@orta
Copy link
Copy Markdown
Contributor

orta commented Jul 26, 2021

I've left some of my ideas on the MDN and docs pages, the tricky thing is making a markdown summary but I've included a pretty reasonable idea for how that could happen.

Re: popup positioning, that's doable - it's just JavaScript and deciding which side is closest to the middle of the page and using that edge to position the popover instead of right now where it's the bottom always. I'd start with maybe doing either above or below first, and then look at left or right

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants