Surround with refactoring

[mjbvz]

Proposal
Add a refactoring that can surround a statement with a try/catch block or potentially other blocks

For example:

class Ranger {
    rick(count: number, precision: number) {
        let result = 'r'
        for (let i = 0; i < count; ++i) 
            result += i.toPrecision(precision)
        return result
    }
}
new Ranger().rick(2, -1)

if a user selects the for block and did a surround with try/catch refactoring, the result would be:

class Ranger {
    rick(count: number, precision: number) {
        let result = 'r'
        try {
            for (let i = 0; i < count; ++i)
                result += i.toPrecision(precision)
        } catch (e) {

        }
        return result
    }
}
new Ranger().rick(2, -1)

[drakarah]

In the above example i would add "throw e;" in the catch block to have the same behaviour until the user changes it, but yes, the "try" and "tryf" snippets would be very handy.

[amcasey]

This seems to already work in VS via the Edit.SurroundWith command. As far as I can tell, it's part of snippet support.

[mhegazy]

Matt Bierner (@mjbvz) can you get the same support in VSCode just with snippets? if not what is missing?

[mjbvz]

Yes, we could use snippets. Are there any smarts that surround-with needs though? Example, for the code:

let a = obj.throwException()
console.log(a)

Surround with on line 1 should generate:

let a;
try {
    a = obj.throwException();
} catch (e) {
     
}
console.log(a)

[mhegazy]

no, but that seems to not have been an issue with VS users.