Simplify temporary name generation logic #2514
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
We still need to get rid of _n, but that can be a separate change.
Contributor
There was a problem hiding this comment.
Why is this better than the TempVariableKind we had previously?
Member
Author
There was a problem hiding this comment.
It's better because it is all in a single tempFlags variable.
Contributor
|
👍, once comments are addressed |
src/compiler/emitter.ts
Outdated
Contributor
There was a problem hiding this comment.
This seems overly dense. It took me several reads just to figure out what it was doing. Can we simplify is as something more like
let set = generatedNameSet || (generatedNameSet = {});
set[generatedName] = generatedName;This helps break out the different concerns. I.e. lazily initializing the set, and adding the element to the set.
Contributor
|
👍 |
ahejlsberg
added a commit
that referenced
this pull request
Mar 27, 2015
Simplify temporary name generation logic
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR we always ensure that temporary names are unique in the source file. This is cheaper than using
resolveNameto ensure uniqueness, plus it is easier to reason about and safer in cases where we didn't reason right.I also combined the dedicated
_iand_ntracking flags and the temp variable counter in a single variable.