Simplify typewriter code. #2745
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
There was a problem hiding this comment.
We don't want this sort of code in the typewriter. It serves no purpose but to hide information.
Member
There was a problem hiding this comment.
This looks good overall. Can we at least skip logging of primitive literals to keep the noise down?
Contributor
Author
|
Logging of primitives is actually important. If, say, we introduce a bug where we screw up primitive typing (say in pull scenarios), we want to know about that for sure. |
CyrusNajmabadi
force-pushed
the
typeWriter
branch
from
22a008b to
29f3f6f
Compare
CyrusNajmabadi
added a commit
that referenced
this pull request
Apr 13, 2015
Simplify typewriter code.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The typewriter code had a lot of specialized checks added to it. This was to keep the baselines non-noisy as we made changes to the typechecker. However, this also meant that its code was getting more and more complex for no appreciable long term gain.
I'm simplifying the typewriter code to always emit types for expressions/identifiers now, and we can use this as the baseline going forward as we make any compiler changes.
Also, we now print the results of getSymbolAtNode as well. Ensuring that if htis information changes, we'll know about it.